ogar-obo: row_schema_of accepts both address forms of an aliased namespace - #294
Conversation
…space The S3 producer flip (#293) set the reader rule at from_concept_id — both 0x0301 and 0x9101 resolve Mondo — but row_schema_of still probed the registry with the RAW concept id, so a pre-flip artifact's legacy ids stopped resolving the carve the moment the registry minted the domain forms. Fold through the namespace alias before the registry probe; concepts without an alias (PATO/RO, spine, foreign) probe as themselves, and 0x0306 / non-OBO ids stay refused.
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_0767c68e-ce5c-4355-88ed-ae656d11037e) |
|
Warning Review limit reachedNext included review available in 56 minutes. View limit detailsLimit details: You’ve used the included review currently available. Your 62 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Included review availability: 0 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour. 📝 WalkthroughWalkthrough
ChangesRow schema lookup
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This localized change makes aliased legacy namespace identifiers resolve to the intended row schema while preserving refusal of unsupported identifiers; no actionable merge-blocking risk remains after normal checks and review. Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
Comment |
The two export constants were literals (0x0303/0x0301) and the flip missed them — resolve_fma rendered 0x9303 while ANATOMY_CLASSID still said 0x0303, caught by MedCare's conformance suite. Derived from Namespace::concept_id() so they can never disagree with the renderer again.
2 participants
Follow-up to #293, found by MedCare's consumption suite: the flip set the reader rule at
from_concept_id(both0x0301and0x9101resolve Mondo), butrow_schema_ofstill probed the registry with the raw concept id — so a pre-flip artifact's legacy ids stopped resolving the row carve the moment the registry minted the domain forms. A legacy artifact carries exactly this carve; its ids must resolve it.Fix: fold through the namespace alias before the registry probe. Concepts without an alias (PATO/RO, spine, foreign) probe as themselves;
0x0306and non-OBO ids stay refused, pinned by the existingforeign_concepts_are_refused_not_guessed.New falsifier
legacy_alias_concepts_resolve_to_the_same_schema(red on the pre-fix code by construction — the legacy trio is in no registry).Gates: ogar-obo 49/49, clippy
--all-targetsclean, fmt clean.🤖 Generated with Claude Code
https://claude.ai/code/session_01PFnYKqw6d7TTiB9cT8eFdK
Generated by Claude Code
Summary by CodeRabbit
0x0301–0x0303now resolve to the same schemas as their canonical IDs.