Skip to content

Adapt to rocq-prover/rocq#22271 #589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xavierleroy merged 2 commits into from
Aug 10, 2026
+7 −1
Merged

Adapt to rocq-prover/rocq#22271 #589

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9469588
Adapt to rocq-prover/rocq#22271
proux01 Jul 13, 2026
0182963
Adapt to rocq-prover/rocq#22271 continued
xavierleroy Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,10 +86,14 @@ MenhirLib/%.vo: COQCOPTS+=-w -deprecated-syntactic-definition -w -deprecated-sin
# warning introduced in 8.20, no alternative before 8.20
# deprecated-from-Coq:
# see above
# unknown-option:
# the "Set Extraction Prefix" command was introduced in 9.4

@SkySkimmer SkySkimmer Aug 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't it make more sense to silence the warning locally?

@xavierleroy xavierleroy Aug 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, this applies only to the extraction/extraction.v file, not the other Rocq source files, so it's rather local already. Plus, I like to put all the warning management in a single file (the Makefile), in the hope that it makes it easier to remove warnings when we drop support for old versions.


COQEXTRACTOPTS ?= \
-w -change-dir-deprecated \
-w -extraction-default-directory \
-w -deprecated-from-Coq
-w -deprecated-from-Coq \
-w -unknown-option

ifneq ($(INSTALL_COQDEV),true)
# Disable costly generation of .cmx files, which are not used locally
Expand Down
2 changes: 2 additions & 0 deletions extraction/extraction.v
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ Require Initializers.
(* Standard lib *)
From Coq Require Import ExtrOcamlBasic ExtrOcamlNativeString.

Set Extraction Prefix "Coq". (* prefix changed to "Rocq" in 9.4 *)

(* Coqlib *)
Extract Inlined Constant Coqlib.proj_sumbool => "(fun x -> x)".

Expand Down
Loading