Fix got missing from the dependency tree (#745) - #748
Merged
Merged
Conversation
AlexGodbehere
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #745.
service-clientimportsgotinlib/deps.jsbut never declared it. Itonly arrived as a hoisted peer of
got-fetch, which is itself optional.npm 11.6.0 (from #743) stops resolving that edge when a lockfile is present,
so v6.9.2 shipped without
gotand services died on their first HTTP call.Changes
lib/js-service-client/package.json:gotandgot-fetchare now realdependencies(1.6.1).got-fetchmoves out ofoptionalDependenciesbecause
build_node_fetch()imports both with no fallback.mk/tools/check-imports.mjs+ a PR workflow: assertslib/js-*declareswhat it imports, so this fails the build next time.
historian-uns: use the in-tree service client. This was pinned at 1.3.6 from npm.