Za/openmetadata - #747
Open
amrc-za wants to merge 21 commits into
Open
Za/openmetadata#747amrc-za wants to merge 21 commits into
amrc-za wants to merge 21 commits into
Conversation
djnewbould
requested changes
Sep 16, 2026
djnewbould
left a comment
djnewbould
left a comment
Contributor
There was a problem hiding this comment.
looks good, just requested a couple of small changes
Comment on lines
+719
to
+753
| openmetadata: | ||
| enabled: true | ||
| fullnameOverride: "openmetadata" | ||
| openmetadata: | ||
| config: | ||
| elasticsearch: | ||
| auth: | ||
| enabled: true | ||
| username: "admin" | ||
| password: | ||
| secretRef: "elasticsearch-secrets" | ||
| secretKey: "openmetadata-elasticsearch-password" | ||
| database: | ||
| enabled: true | ||
| host: mysql | ||
| port: 3306 | ||
| driverClass: com.mysql.cj.jdbc.Driver | ||
| dbScheme: mysql | ||
| databaseName: openmetadata_db | ||
| auth: | ||
| username: openmetadata_user | ||
| password: | ||
| secretRef: openmetadata-mysql-secrets | ||
| secretKey: mysql-password | ||
| pipelineServiceClientConfig: | ||
| airflow: | ||
| auth: | ||
| enabled: true | ||
| username: admin | ||
| password: | ||
| secretRef: airflow-secrets | ||
| secretKey: openmetadata-airflow-password | ||
|
|
||
| openmetadata-dependencies: | ||
| enabled: true |
Contributor
There was a problem hiding this comment.
I think openmetadata and openmetadata-dependencies should be false by default, the stack it deploys is pretty resource heavy and I don't think every deployment would need it.
Contributor
Author
There was a problem hiding this comment.
disabled by default
Comment on lines
+8
to
+9
| .claude/ | ||
| .devcontainer/ |
Contributor
There was a problem hiding this comment.
Do these two folders need to be git ignored? we ignore specific files in these folders already
Contributor
Author
There was a problem hiding this comment.
removed from gitignore
removed the custom one because opensearch helm chart already provides service
… new and flatten docker images
…updated values.yaml
amrc-za
force-pushed
the
za/openmetadata
branch
from
September 16, 2026 14:26
666e756 to
67774cd
Compare
djnewbould
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Openmetadata 2.0.1 is added as a new ACS service through official openmetadata helm charts.