fix(antigravity): Attach prompt to -p flag - #69
Merged
Conversation
agy -p takes the prompt as its value, so a bare -p up front swallowed --output-format as the prompt and left the real prompt as a stray positional. Every antigravity session failed at spawn with '-p took --output-format as its prompt'. Pass -p=<prompt> last instead, which also stays unambiguous when the prompt starts with a dash.
agy models separates id and display name with a single TAB, but the parser split on two-or-more spaces, so every catalog id carried the display name along (id\tname). Those dirty ids were stored in role bindings and agy rejected them at spawn with 'invalid model selection'. Split on TAB first, fall back to column spacing, and drop the banner line that also leaked into the catalog.
Review feedback on PR #69: the dash-leading prompt and the spinner banner branch had verification only via throwaway probes. Pin both in the scoped suite.
|
4ndreello
marked this pull request as ready for review
September 8, 2026 18:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the two antigravity spawn failures behind every failed reviewer session
Commit 1: agy
-ptakes the prompt as its value, so a bare-pup frontswallowed
--output-formatas the prompt and left the real prompt as astray positional (
-p took "--output-format" as its prompt). The promptnow goes attached as
-p=<prompt>at the end of the argv, which alsostays unambiguous when the prompt starts with a dash.
Commit 2:
agy modelsseparates id and display name with a single TAB,but the parser split on two-or-more spaces, so every catalog id carried
the display name along. Those dirty ids landed in role bindings and agy
rejected them at spawn (
invalid model selection). The parser now splitson TAB first, falls back to column spacing, and drops the banner line
that also leaked into the catalog.
Verified with the exact argv the driver builds, run against the real agy:
plain prompt, leading-dash prompt, and resume plus model plus effort all
return
result SUCCESS. Scoped unit tests pass(tests/antigravity-driver.test.ts, 18 tests).
codedeck models antigravity --refreshnow lists clean ids, and the reviewer/auditorbindings save as bare ids.
Needs a careful look at whether
-p=or a trailing separate-pvaluereads better for future flag additions.