Skip to content

fix(web): Keep canvas zoom out of the detail panel scroll #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
4ndreello merged 1 commit into from
Sep 8, 2026
+15 −2
Merged

fix(web): Keep canvas zoom out of the detail panel scroll #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions src/web/canvas-page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ export const CANVAS_PAGE: string = `<!doctype html>
#feed li.fresh { color: #f5f5f7; }
@keyframes feedIn { from { opacity: 0; transform: translateY(-5px); } to { opacity: 1; } }
#hint { left: 50%; transform: translateX(-50%); bottom: 16px; font-size: 12px; color: #98989f; white-space: nowrap; }
#detail { position: fixed; top: 0; right: 0; bottom: 0; width: min(360px, 92vw); z-index: 20;
#detail { position: fixed; top: 0; right: 0; bottom: 0; width: min(400px, 94vw); z-index: 20;
background: rgba(10, 12, 16, 0.92); border-left: 1px solid rgba(255,255,255,0.1);
backdrop-filter: blur(14px); padding: 18px; overflow-y: auto; display: none; }
#detail.open { display: block; }
Expand All @@ -69,7 +69,14 @@ export const CANVAS_PAGE: string = `<!doctype html>
border: 1px solid rgba(255,255,255,0.12); background: transparent; color: #98989f;
cursor: pointer; font-size: 14px; line-height: 1; font-family: inherit; }
#detailClose:hover { color: #f5f5f7; border-color: rgba(255,255,255,0.25); }
#dChat { border: 1px solid rgba(255,255,255,0.08); border-radius: 10px; padding: 10px; max-height: 34vh; overflow-y: auto; display: flex; flex-direction: column; gap: 9px; }
#dChat { border: 1px solid rgba(255,255,255,0.08); border-radius: 10px; padding: 10px; max-height: 52vh; min-height: 140px; overflow-y: auto; display: flex; flex-direction: column; gap: 9px; }
/* Scroll fino escuro no painel e no chat (Firefox + WebKit): o padrao
claro do SO quebra o tema escuro da pagina. */
#detail, #dChat { scrollbar-width: thin; scrollbar-color: rgba(255,255,255,0.24) transparent; }
#detail::-webkit-scrollbar, #dChat::-webkit-scrollbar { width: 10px; }
#detail::-webkit-scrollbar-track, #dChat::-webkit-scrollbar-track { background: transparent; }
#detail::-webkit-scrollbar-thumb, #dChat::-webkit-scrollbar-thumb { background-color: rgba(255,255,255,0.18); border-radius: 8px; border: 3px solid transparent; background-clip: content-box; }
#detail::-webkit-scrollbar-thumb:hover, #dChat::-webkit-scrollbar-thumb:hover { background-color: rgba(255,255,255,0.32); }
#dChat .msg { font-size: 12.5px; line-height: 1.45; white-space: pre-wrap; word-break: break-word; padding: 7px 9px; border-radius: 9px; }
#dChat .msg .who { display: block; font-size: 10.5px; letter-spacing: 0.04em; color: #98989f; margin-bottom: 2px; }
#dChat .msg.user { background: rgba(10,132,255,0.16); }
Expand Down Expand Up @@ -789,6 +796,10 @@ window.addEventListener("keydown", function (ev) {
if (ev.key === "Escape") closeDetail();
});
window.addEventListener("wheel", function (ev) {
// O painel de detalhe tem scroll proprio (#detail e #dChat): o zoom do
// canvas so vale fora dele, senao rolar o chat daria zoom na cena.
var t = ev.target;
if (t && typeof t.closest === "function" && t.closest("#detail")) return;
ev.preventDefault();
var before = toWorld(ev.clientX, ev.clientY);
cam.zoom = Math.min(2.2, Math.max(0.45, cam.zoom * (ev.deltaY < 0 ? 1.1 : 0.9)));
Expand Down
2 changes: 2 additions & 0 deletions tests/web-command.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,6 +317,8 @@ describe("canvas page", () => {
],
["chat transcript and send box", ['id="dChat"', 'id="dSend"', "/logs", "/send"]],
["hidden-by-default filter", ['qp0.get("hide") !== "0"', 'qp.set("hide", "0")']],
["wheel skips zoom inside the detail panel", ['closest("#detail")']],
["roomier chat with dark thin scrollbars", ["52vh", "scrollbar-width", "::-webkit-scrollbar"]],
];
for (const [feature, needs] of markerGroups) {
it(`has the ${feature}`, () => {
Expand Down
Loading