Skip to content

fix: update ParagraphDocumentContent rendering condition in index.vue - #6594

Merged
liuruibin merged 1 commit into
v2from
pr@v2@fix_pdf
Aug 6, 2026
Merged

fix: update ParagraphDocumentContent rendering condition in index.vue#6594
liuruibin merged 1 commit into
v2from
pr@v2@fix_pdf

Conversation

@shaohuzhang1

Copy link
Copy Markdown
Contributor

fix: update ParagraphDocumentContent rendering condition in index.vue

Copilot AI lite review requested due to automatic review settings August 6, 2026 02:12
@shaohuzhang1

Copy link
Copy Markdown
Contributor Author

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Ready to approve

The change fixes an objectively incorrect v-else pairing that could render the wrong component for non-execution-detail panel types, and the import cleanup is consistent and safe.

This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.

Pull request overview

Fixes right-side panel rendering in the PC chat view by ensuring ParagraphDocumentContent is only rendered when the active panel type is paragraphDocument, preventing it from incorrectly showing up for other panel types.

Changes:

  • Replace the v-else fallback with an explicit v-if="rightPanelType === 'paragraphDocument'" for ParagraphDocumentContent.
  • Remove the unused watch import and tidy the vue named import ordering.
File summaries
File Description
ui/src/views/chat/pc/index.vue Corrects right panel conditional rendering so paragraph document content only appears for the paragraph-document panel type.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.

@liuruibin
liuruibin merged commit 01b21db into v2 Aug 6, 2026
5 of 7 checks passed
@liuruibin
liuruibin deleted the pr@v2@fix_pdf branch August 6, 2026 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants