docs: correct quote expiry to 15 minutes in api reference - #115
Merged
Merged
Conversation
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
Quotes are valid for 15 minutes, not 5. CommitIntent does not create a separate 10-minute window — committed intents share the same 15-minute quote expiry checked by ExecuteIntent on a QUOTED intent. #110 landed with the wrong timings; correcting them here. Source of truth: 0xsequence/trails-api release - lib/intentmachine/handle_quote.go:476-478 — "Set intent expiry to 15 minutes: gives users enough time for QR scanning and slow wallets." Sets intent.ExpiresAt = time.Now().Add(15 * time.Minute). - lib/intentmachine/handle_commit.go:80 — CommitIntent rejects when dbIntent.QuoteExpired() using the same ExpiresAt; no separate committed-window bump. Files updated: - api-reference/endpoints/quote-intent.mdx — 5 → 15 minutes - api-reference/endpoints/execute-intent.mdx — 5 → 15; drop bogus "10 minutes after CommitIntent" window - api-reference/endpoints/execute-intent-edge.mdx — 5 → 15 minutes - api-reference/endpoints/commit-intent.mdx — replace bogus 10-minute post-commit window with the shared quote expiry - api-reference/introduction.mdx — quickstart warning + timing table Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017M77Ao94G6NcdUGvVMyNzT
ScreamingHawk
force-pushed
the
docs/fix-quote-expiry-timing-2026-09-17
branch
from
September 17, 2026 03:24
c615d5f to
7bb0b5c
Compare
Contributor
|
Initial concern in 110 already fixed and merged. Updating PR to keep other detected issues |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Corrects a factual error introduced by #110: quotes are valid for 15 minutes, not 5, and
CommitIntentdoes not add a separate 10-minute post-commit window — committed intents share the same 15-minute quote expiry.api-reference/endpoints/quote-intent.mdx— 5 → 15 minutesapi-reference/endpoints/execute-intent.mdx— 5 → 15 minutes; remove the bogus "10 minutes afterCommitIntent" claimapi-reference/endpoints/execute-intent-edge.mdx— 5 → 15 minutesapi-reference/endpoints/commit-intent.mdx— replace the bogus 10-minute post-commit window with the shared quote expiryapi-reference/introduction.mdx— quickstart warning + timing tableSource of truth
0xsequence/trails-apirelease branch:lib/intentmachine/handle_quote.go:476-478— setsintent.ExpiresAt = time.Now().Add(15 * time.Minute)with the comment: "Set intent expiry to 15 minutes: gives users enough time for QR scanning and slow wallets."lib/intentmachine/handle_commit.go—CommitIntentrejects whendbIntent.QuoteExpired()using the sameExpiresAt; there is no separate committed-window bump.Also confirmed by
ScreamingHawk's correction commit on #112 (docs: quote expiry is 15 minutes), which fixes the same claim inuse-cases/fund.mdx.Verification
grep -rn '5 minutes\|10 minutes\|15 minutes' api-reference/— after this PR, only15 minutesappears in the API-reference timing text.trails-apirelease at HEAD.use-cases/fund.mdxorresources/llm-integration.mdx; docs: update use case examples 2026-08-31 #112 already fixes the timing in those files.Generated by the Trails Docs weekly agent (follow-up on a maintainer correction to #112).
🤖 Generated with Claude Code
https://claude.ai/code/session_017M77Ao94G6NcdUGvVMyNzT
Generated by Claude Code