From 0db76cad8300000544197646068d8edb0ac57dd5 Mon Sep 17 00:00:00 2001 From: Yifan Chen Date: Sat, 5 Sep 2026 20:10:44 -0700 Subject: [PATCH 1/2] Remove unreachable aborted-signal check and fix two unparseable steps MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit `registerTool()` checks the same aborted signal twice. #240 added an early check before the `exposedTo` validation but left the original in place inside the signal block. Between the two, the algorithm only builds a list of origins, runs the URL parser, and creates a promise — no step yields to the event loop or invokes author code, so the signal's aborted flag cannot change and the second check is dead. Removing the later one preserves #240's intent, which was to let an aborted signal win over a `SecurityError`. `getTools()` reads "If |toolOwnerIsRequested| be true if ...", which binds nothing; the next step reads that variable, so the step is a `Let`. `registerTool()` dereferences a bare {{ModelContextTool/description}} with no object to read it from. Every other member access in the algorithm is written |tool|'s {{ModelContextTool/...}}. The |tool name| half of the same step is already covered by the next step, so this drops it rather than repeating it. --- index.bs | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/index.bs b/index.bs index 46c95ea..38483d0 100644 --- a/index.bs +++ b/index.bs @@ -669,7 +669,7 @@ The registerTool(tool, optionsregisterTool(tool, optionsgetTools(options) method steps 1. Let |callerOrigin| be |toolRequestor|'s [=Document/origin=]. - 1. If |toolOwnerIsRequested| be true if |targetOrigin| is [=same origin=] with |callerOrigin|, - or if |from origins| [=list/contains=] |targetOrigin|; otherwise, false. + 1. Let |toolOwnerIsRequested| be true if |targetOrigin| is [=same origin=] with + |callerOrigin|, or if |from origins| [=list/contains=] |targetOrigin|; otherwise, false. 1. If |toolOwnerIsRequested| is false, then [=iteration/continue=]. From 63a8b3ed27275f208d9b0e9ec29cd5dc7fb975a6 Mon Sep 17 00:00:00 2001 From: Yifan Chen Date: Fri, 11 Sep 2026 09:08:44 -0700 Subject: [PATCH 2/2] Address registerTool review feedback --- index.bs | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/index.bs b/index.bs index 38483d0..9d418a4 100644 --- a/index.bs +++ b/index.bs @@ -669,13 +669,12 @@ The registerTool(tool, optionsregisterTool(tool, options