Recommended way to position drawing within canvas?

[jordan-loeser]

What is the recommended way to change the position where the bitmap is drawn on the canvas using draw2canvas()? I noticed that x and y are hardcoded to start at 0 in the function definition (below) and using context.moveTo() does not seem to have any effect.

bdfparser-js/src/bdfparser.ts

Lines 1796 to 1829 in 71a4ee3

	/**
	* Draw the bitmap to HTML canvas
	*
	* @param context - Canvas 2D context (`canvas.getContext("2d")`)
	* @param pixelcolors - Object mapping `'0'`/`'1'`/`'2'` in the bitmap data to color
	*
	* @returns The `Bitmap` object itself
	*
	* @see online docs: {@link https://font.tomchen.org/bdfparser_js/bitmap#draw2canvas}
	*/
	draw2canvas(
	context: CanvasContext,
	pixelcolors?: Record<'0' | '1' | '2', string | null> | null
	): this {
	const _pixelcolors = pixelcolors ?? {
	'0': null,
	'1': 'black',
	'2': 'red',
	}
	this.todata(2).forEach((line, y) => {
	line.forEach((pixel, x) => {
	const s = pixel.toString()
	if (s === '0' || s === '1' || s === '2') {
	const color = _pixelcolors[s]
	if (color !== null && color !== undefined) {
	context.fillStyle = color
	context.fillRect(x, y, 1, 1)
	}
	}
	})
	})
	return this
	}
	}

[jordan-loeser]

I created a PR #3 that might be one way of doing this internally without using transformations.

[tomchen]

@jordan-loeser Hi, I plan to update bdfparser js and python libs soon to v3, merging all PRs, solving all issues, and adding a feature to generate pixelated SVG from Bitmap (and perhaps even convert an entire BDF font to pixelated SVG font, which would be a little complicated to implement but very useful though)

I'm wondering if I can apply your modification in PR #3, which was closed because you deleted your branch, but I suppose that was not because you thought your modif was bad but just to clean up your forked repos, right? I guess it's good to add x, y as new options in draw2canvas().