From f49b8cfa4c51a1837d5ced650ec99d0ec4fe11ab Mon Sep 17 00:00:00 2001 From: Drew Stone Date: Tue, 1 Sep 2026 17:57:42 -0600 Subject: [PATCH] docs(scripts): the version-gate roster names the two repositories that carry it The header claimed these files are kept byte-identical in three repositories. Two carry them. agent-eval has never had check-version-bump.mjs, check-api-surface.mjs, lib/api-surface.mjs or api-surface.json on main, and no CI step that runs them. The only copy sits on `feat/export-surface-gate`, written 2026-08-18, unmerged, and 59 commits behind main on 2026-09-01. That branch's own copy of check-version-bump.mjs had already drifted from this one before the published-baseline fix existed, so the three-name roster was never true. The correction names exactly the two repositories that carry the file and says why the third is absent, so nobody restores it on the strength of the sentence alone. The stale count in check-api-surface.mjs goes with it: "three copies of one rule end up with three different bugs" was tied to the same roster, and now reads count-free. Adopting the gate in agent-eval is a decision about that repository's release discipline, not an edit this file is owed. It has an open release train, and a new gate switched on mid-flight would red it. Tracked as tangle-network/agent-eval#729. Byte-identity with agent-runtime is preserved: the same patch lands in tangle-network/agent-runtime#1075. Documentation only. No behavior changes. --- scripts/check-api-surface.mjs | 4 ++-- scripts/check-version-bump.mjs | 15 ++++++++++++--- 2 files changed, 14 insertions(+), 5 deletions(-) diff --git a/scripts/check-api-surface.mjs b/scripts/check-api-surface.mjs index 6f08b23..4f6c08c 100644 --- a/scripts/check-api-surface.mjs +++ b/scripts/check-api-surface.mjs @@ -35,8 +35,8 @@ * requirement rather than a preference. This repository set spans TypeScript 6 * and TypeScript 7, and TypeScript 7 ships no JavaScript compiler API at all — * `ts.createProgram` is undefined there. A checker-based extractor would work - * in one repository and have to be rewritten in the others, which is how three - * copies of one rule end up with three different bugs. `oxc-parser` presents + * in one repository and have to be rewritten in the others, which is how copies + * of one rule end up with a different bug each. `oxc-parser` presents * the same API on every repository and parses the declaration dialect the * build already emits through the same parser family. * diff --git a/scripts/check-version-bump.mjs b/scripts/check-version-bump.mjs index faece75..02163fa 100644 --- a/scripts/check-version-bump.mjs +++ b/scripts/check-version-bump.mjs @@ -61,9 +61,18 @@ * `requiredBumpLevel` in `lib/api-surface.mjs`. * * This file, `check-api-surface.mjs` and `lib/api-surface.mjs` are kept - * byte-identical in agent-eval, agent-knowledge and agent-runtime. They read - * everything repo-specific out of the manifests they inspect, so an edit to one - * belongs in all three. Nothing here may name a single repository. + * byte-identical in agent-knowledge and agent-runtime. They read everything + * repo-specific out of the manifests they inspect, so an edit to one belongs in + * both. Nothing here may name a single repository. + * + * agent-eval is deliberately NOT in that set, and the roster that used to name it + * was never true: it has never carried these files on main. Its copy sits on an + * unmerged branch, `feat/export-surface-gate`, written 2026-08-18 and 59 commits + * behind main on 2026-09-01, whose own copy of this file had already drifted from + * this one before the fix below existed. Adopting the gate there is a decision + * about that repository's release discipline, not an edit this file is owed, so + * it is tracked as its own issue. Restore the third name only when agent-eval + * actually carries the file. * * The version a change is measured against is the LAST PUBLISHED one, not the * base branch's. Those differ whenever main already carries a bump that has not