From fdf88a0a7076b2fe0794d0ec5ae5fdd2224d6243 Mon Sep 17 00:00:00 2001 From: Claude Date: Sun, 20 Sep 2026 21:14:12 +0000 Subject: [PATCH 1/2] test: migrate `stats/base/dists/lognormal/skewness` to ULP-based assertions Ref: https://github.com/stdlib-js/stdlib/issues/11352 Co-Authored-By: Claude Sonnet 5 Claude-Session: https://claude.ai/code/session_01Nj1i4n5fSMXew7XM8dHy93 --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- .../base/dists/lognormal/skewness/test/test.js | 13 ++----------- .../dists/lognormal/skewness/test/test.native.js | 13 ++----------- 2 files changed, 4 insertions(+), 22 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/lognormal/skewness/test/test.js b/lib/node_modules/@stdlib/stats/base/dists/lognormal/skewness/test/test.js index 362659a5fa24..c2fb18e009f2 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/lognormal/skewness/test/test.js +++ b/lib/node_modules/@stdlib/stats/base/dists/lognormal/skewness/test/test.js @@ -21,11 +21,10 @@ // MODULES // var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var skewness = require( './../lib' ); @@ -76,9 +75,7 @@ tape( 'if provided a nonpositive `sigma`, the function returns `NaN`', function tape( 'the function returns the skewness of a lognormal distribution', function test( t ) { var expected; - var delta; var sigma; - var tol; var mu; var y; var i; @@ -89,13 +86,7 @@ tape( 'the function returns the skewness of a lognormal distribution', function for ( i = 0; i < mu.length; i++ ) { y = skewness( mu[i], sigma[i] ); if ( expected[i] !== null ) { - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'mu:'+mu[i]+', sigma: '+sigma[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. mu: '+mu[i]+'. sigma: '+sigma[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } } t.end(); diff --git a/lib/node_modules/@stdlib/stats/base/dists/lognormal/skewness/test/test.native.js b/lib/node_modules/@stdlib/stats/base/dists/lognormal/skewness/test/test.native.js index 9aad27049b2b..3e58b7a38e17 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/lognormal/skewness/test/test.native.js +++ b/lib/node_modules/@stdlib/stats/base/dists/lognormal/skewness/test/test.native.js @@ -23,11 +23,10 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); var tryRequire = require( '@stdlib/utils/try-require' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); // FIXTURES // @@ -88,9 +87,7 @@ tape( 'if provided a nonpositive `sigma`, the function returns `NaN`', opts, fun tape( 'the function returns the skewness of a lognormal distribution', opts, function test( t ) { var expected; - var delta; var sigma; - var tol; var mu; var y; var i; @@ -101,13 +98,7 @@ tape( 'the function returns the skewness of a lognormal distribution', opts, fun for ( i = 0; i < mu.length; i++ ) { y = skewness( mu[i], sigma[i] ); if ( expected[i] !== null) { - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'mu:'+mu[i]+', sigma: '+sigma[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. mu: '+mu[i]+'. sigma: '+sigma[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } } t.end(); From 1bb422f2a8e54675552053ae3126d73c63c49faf Mon Sep 17 00:00:00 2001 From: Athan Date: Mon, 21 Sep 2026 00:37:46 -0700 Subject: [PATCH 2/2] style: add missing space Signed-off-by: Athan --- .../stats/base/dists/lognormal/skewness/test/test.native.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/lognormal/skewness/test/test.native.js b/lib/node_modules/@stdlib/stats/base/dists/lognormal/skewness/test/test.native.js index 3e58b7a38e17..744a0044c1e9 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/lognormal/skewness/test/test.native.js +++ b/lib/node_modules/@stdlib/stats/base/dists/lognormal/skewness/test/test.native.js @@ -97,7 +97,7 @@ tape( 'the function returns the skewness of a lognormal distribution', opts, fun sigma = data.sigma; for ( i = 0; i < mu.length; i++ ) { y = skewness( mu[i], sigma[i] ); - if ( expected[i] !== null) { + if ( expected[i] !== null ) { t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } }