From 66e448082cb15129815fa8956f1ce712141d7f93 Mon Sep 17 00:00:00 2001 From: Claude Date: Sun, 20 Sep 2026 14:15:14 +0000 Subject: [PATCH] test: migrate `stats/base/dists/bernoulli/kurtosis` to ULP-based assertions Replaces the relative tolerance (`EPS`-scaled) fixture comparisons in `test/test.js` and `test/test.native.js` with ULP difference testing via `@stdlib/assert/is-almost-same-value`. All 1000 Julia fixture values match bit-for-bit, so the minimum required ULP bound is 0. Ref: https://github.com/stdlib-js/stdlib/issues/11352 Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_01FAk9ZwMqUXA4W8o4t7dbtQ --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- .../base/dists/bernoulli/kurtosis/test/test.js | 13 ++----------- .../dists/bernoulli/kurtosis/test/test.native.js | 13 ++----------- 2 files changed, 4 insertions(+), 22 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/bernoulli/kurtosis/test/test.js b/lib/node_modules/@stdlib/stats/base/dists/bernoulli/kurtosis/test/test.js index 64053ea160d6..833af076e79a 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/bernoulli/kurtosis/test/test.js +++ b/lib/node_modules/@stdlib/stats/base/dists/bernoulli/kurtosis/test/test.js @@ -21,11 +21,10 @@ // MODULES // var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var kurtosis = require( './../lib' ); @@ -78,8 +77,6 @@ tape( 'if provided a success probability `p` outside of `[0,1]`, the function re tape( 'the function returns the excess kurtosis of a Bernoulli distribution', function test( t ) { var expected; - var delta; - var tol; var i; var p; var y; @@ -88,13 +85,7 @@ tape( 'the function returns the excess kurtosis of a Bernoulli distribution', fu p = data.p; for ( i = 0; i < expected.length; i++ ) { y = kurtosis( p[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'p: '+p[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. p: '+p[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/stats/base/dists/bernoulli/kurtosis/test/test.native.js b/lib/node_modules/@stdlib/stats/base/dists/bernoulli/kurtosis/test/test.native.js index f059b2f405f0..a117a87e19e6 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/bernoulli/kurtosis/test/test.native.js +++ b/lib/node_modules/@stdlib/stats/base/dists/bernoulli/kurtosis/test/test.native.js @@ -22,12 +22,11 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var tryRequire = require( '@stdlib/utils/try-require' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); // FIXTURES // @@ -87,8 +86,6 @@ tape( 'if provided a success probability `p` outside of `[0,1]`, the function re tape( 'the function returns the excess kurtosis of a Bernoulli distribution', opts, function test( t ) { var expected; - var delta; - var tol; var i; var p; var y; @@ -97,13 +94,7 @@ tape( 'the function returns the excess kurtosis of a Bernoulli distribution', op p = data.p; for ( i = 0; i < expected.length; i++ ) { y = kurtosis( p[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'p: '+p[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. p: '+p[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } t.end(); });