From 6e1e57db4adfb4fa75a630d85e14f0c715199fa0 Mon Sep 17 00:00:00 2001 From: Claude Date: Sun, 20 Sep 2026 09:17:09 +0000 Subject: [PATCH] test: migrate `stats/base/dists/cauchy/logcdf` to ULP-based assertions Replaces relative-tolerance (EPS-based) comparisons in the fixture-driven test cases with `@stdlib/assert/is-almost-same-value` ULP-difference assertions. Co-Authored-By: Claude Sonnet 5 Claude-Session: https://claude.ai/code/session_012tvj9d3aJCYgSsmTcKwDZ5 --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- .../dists/cauchy/logcdf/test/test.factory.js | 33 +++---------------- .../dists/cauchy/logcdf/test/test.logcdf.js | 33 +++---------------- .../dists/cauchy/logcdf/test/test.native.js | 33 +++---------------- 3 files changed, 12 insertions(+), 87 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/cauchy/logcdf/test/test.factory.js b/lib/node_modules/@stdlib/stats/base/dists/cauchy/logcdf/test/test.factory.js index fdf187811e00..24b69dd7d992 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/cauchy/logcdf/test/test.factory.js +++ b/lib/node_modules/@stdlib/stats/base/dists/cauchy/logcdf/test/test.factory.js @@ -21,11 +21,10 @@ // MODULES // var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var factory = require( './../lib/factory.js' ); @@ -139,9 +138,7 @@ tape( 'if provided a nonpositive `gamma`, the created function always returns `N tape( 'the created function evaluates the logcdf for `x` given `x0` and `gamma` (large gamma)', function test( t ) { var expected; var logcdf; - var delta; var gamma; - var tol; var x0; var i; var x; @@ -154,13 +151,7 @@ tape( 'the created function evaluates the logcdf for `x` given `x0` and `gamma` for ( i = 0; i < x.length; i++ ) { logcdf = factory( x0[i], gamma[i] ); y = logcdf( x[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', x0:'+x0[i]+', gamma: '+gamma[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 7.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. x0: '+x0[i]+'. gamma: '+gamma[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 9 ), true, 'returns expected value' ); } t.end(); }); @@ -168,9 +159,7 @@ tape( 'the created function evaluates the logcdf for `x` given `x0` and `gamma` tape( 'the created function evaluates the logcdf for `x` given `x0` and `gamma` (`x0 < 0`)', function test( t ) { var expected; var logcdf; - var delta; var gamma; - var tol; var x0; var i; var x; @@ -183,13 +172,7 @@ tape( 'the created function evaluates the logcdf for `x` given `x0` and `gamma` for ( i = 0; i < x.length; i++ ) { logcdf = factory( x0[i], gamma[i] ); y = logcdf( x[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', x0:'+x0[i]+', gamma: '+gamma[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 7.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. x0: '+x0[i]+'. gamma: '+gamma[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 12 ), true, 'returns expected value' ); } t.end(); }); @@ -197,9 +180,7 @@ tape( 'the created function evaluates the logcdf for `x` given `x0` and `gamma` tape( 'the created function evaluates the logcdf for `x` given `x0` and `gamma` (`x0 > 0`)', function test( t ) { var expected; var logcdf; - var delta; var gamma; - var tol; var x0; var i; var x; @@ -212,13 +193,7 @@ tape( 'the created function evaluates the logcdf for `x` given `x0` and `gamma` for ( i = 0; i < x.length; i++ ) { logcdf = factory( x0[i], gamma[i] ); y = logcdf( x[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', x0:'+x0[i]+', gamma: '+gamma[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 7.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. x0: '+x0[i]+'. gamma: '+gamma[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 6 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/stats/base/dists/cauchy/logcdf/test/test.logcdf.js b/lib/node_modules/@stdlib/stats/base/dists/cauchy/logcdf/test/test.logcdf.js index b20b7127d274..98f364ad46d2 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/cauchy/logcdf/test/test.logcdf.js +++ b/lib/node_modules/@stdlib/stats/base/dists/cauchy/logcdf/test/test.logcdf.js @@ -21,11 +21,10 @@ // MODULES // var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var logcdf = require( './../lib' ); @@ -95,9 +94,7 @@ tape( 'if provided a nonpositive `gamma`, the function always returns `NaN`', fu tape( 'the function evaluates the logcdf for `x` given `x0` and `gamma` (large `gamma`)', function test( t ) { var expected; - var delta; var gamma; - var tol; var x0; var x; var y; @@ -109,22 +106,14 @@ tape( 'the function evaluates the logcdf for `x` given `x0` and `gamma` (large ` gamma = largeGamma.gamma; for ( i = 0; i < x.length; i++ ) { y = logcdf( x[i], x0[i], gamma[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', x0:'+x0[i]+', gamma: '+gamma[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 7.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. x0: '+x0[i]+'. gamma: '+gamma[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 9 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function evaluates the logcdf for `x` given `x0` and `gamma` (`x0 < 0`)', function test( t ) { var expected; - var delta; var gamma; - var tol; var x0; var x; var y; @@ -136,22 +125,14 @@ tape( 'the function evaluates the logcdf for `x` given `x0` and `gamma` (`x0 < 0 gamma = negativeMedian.gamma; for ( i = 0; i < x.length; i++ ) { y = logcdf( x[i], x0[i], gamma[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', x0:'+x0[i]+', gamma: '+gamma[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 7.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. x0: '+x0[i]+'. gamma: '+gamma[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 12 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function evaluates the logcdf for `x` given `x0` and `gamma` (`x0 > 0`)', function test( t ) { var expected; - var delta; var gamma; - var tol; var x0; var x; var y; @@ -163,13 +144,7 @@ tape( 'the function evaluates the logcdf for `x` given `x0` and `gamma` (`x0 > 0 gamma = positiveMedian.gamma; for ( i = 0; i < x.length; i++ ) { y = logcdf( x[i], x0[i], gamma[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', x0:'+x0[i]+', gamma: '+gamma[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 7.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. x0: '+x0[i]+'. gamma: '+gamma[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 6 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/stats/base/dists/cauchy/logcdf/test/test.native.js b/lib/node_modules/@stdlib/stats/base/dists/cauchy/logcdf/test/test.native.js index 75a5f9400ce5..0a4d19914a23 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/cauchy/logcdf/test/test.native.js +++ b/lib/node_modules/@stdlib/stats/base/dists/cauchy/logcdf/test/test.native.js @@ -23,11 +23,10 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); var tryRequire = require( '@stdlib/utils/try-require' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); // FIXTURES // @@ -104,9 +103,7 @@ tape( 'if provided a nonpositive `gamma`, the function always returns `NaN`', op tape( 'the function evaluates the logcdf for `x` given `x0` and `gamma` (large `gamma`)', opts, function test( t ) { var expected; - var delta; var gamma; - var tol; var x0; var x; var y; @@ -118,22 +115,14 @@ tape( 'the function evaluates the logcdf for `x` given `x0` and `gamma` (large ` gamma = largeGamma.gamma; for ( i = 0; i < x.length; i++ ) { y = logcdf( x[i], x0[i], gamma[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', x0:'+x0[i]+', gamma: '+gamma[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 7.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. x0: '+x0[i]+'. gamma: '+gamma[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 9 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function evaluates the logcdf for `x` given `x0` and `gamma` (`x0 < 0`)', opts, function test( t ) { var expected; - var delta; var gamma; - var tol; var x0; var x; var y; @@ -145,22 +134,14 @@ tape( 'the function evaluates the logcdf for `x` given `x0` and `gamma` (`x0 < 0 gamma = negativeMedian.gamma; for ( i = 0; i < x.length; i++ ) { y = logcdf( x[i], x0[i], gamma[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', x0:'+x0[i]+', gamma: '+gamma[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 300.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. x0: '+x0[i]+'. gamma: '+gamma[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 12 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function evaluates the logcdf for `x` given `x0` and `gamma` (`x0 > 0`)', opts, function test( t ) { var expected; - var delta; var gamma; - var tol; var x0; var x; var y; @@ -172,13 +153,7 @@ tape( 'the function evaluates the logcdf for `x` given `x0` and `gamma` (`x0 > 0 gamma = positiveMedian.gamma; for ( i = 0; i < x.length; i++ ) { y = logcdf( x[i], x0[i], gamma[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', x0:'+x0[i]+', gamma: '+gamma[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 220.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. x0: '+x0[i]+'. gamma: '+gamma[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 6 ), true, 'returns expected value' ); } t.end(); });