From 0b0401b66ce7c6020167b39475a78dd66a91c5e8 Mon Sep 17 00:00:00 2001 From: Cursor Agent Date: Fri, 4 Sep 2026 07:11:33 +0000 Subject: [PATCH] chore: stop auto-requesting Erik as a reviewer Cursor's PR routing agent picks reviewers from commit history, so cursor[bot] has been requesting @erikarenhill on almost every agent PR. The GitHub Discord bot then pings him a few times a day. Request reviews only from CODEOWNERS for changed paths. He is not one. Humans can still request him when they actually need him. Signed-off-by: Cursor Agent Co-authored-by: Fredrik Ahlgren --- .cursor/approval-policies/ROUTING.md | 5 ++++ .github/CODEOWNERS | 3 +++ AGENTS.md | 4 +++ APPROVAL_POLICY.md | 37 ++++++++++++++++++++++++++++ 4 files changed, 49 insertions(+) create mode 100644 .cursor/approval-policies/ROUTING.md create mode 100644 APPROVAL_POLICY.md diff --git a/.cursor/approval-policies/ROUTING.md b/.cursor/approval-policies/ROUTING.md new file mode 100644 index 00000000..67a943fb --- /dev/null +++ b/.cursor/approval-policies/ROUTING.md @@ -0,0 +1,5 @@ +- product: ftw + boundary: / + policies: + - APPROVAL_POLICY.md + - Request GitHub reviews only from .github/CODEOWNERS for paths this PR changes. Never request erikarenhill. Do not select reviewers from commit history. diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 707525c8..99674c35 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -6,6 +6,7 @@ # This is about who gets asked, not who is allowed to contribute. # Web/UI changes require a human visual check; see AGENTS.md. +# Do not auto-request @erikarenhill; he is not a CODEOWNER. # Drivers and the Lua host. /drivers/ @frahlg @@ -15,3 +16,5 @@ /.github/ @frahlg /AGENTS.md @frahlg /CLAUDE.md @frahlg +/APPROVAL_POLICY.md @frahlg +/.cursor/ @frahlg diff --git a/AGENTS.md b/AGENTS.md index 0aab247b..9970a909 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -87,6 +87,10 @@ landed on somebody else's finished work. badly while it waits. - **Respect `.github/CODEOWNERS`.** An owner reviews what lands in their area, whoever — or whatever — wrote it. +- **Do not request GitHub reviews except CODEOWNERS.** Never request + @erikarenhill and never @mention people for attention — the GitHub + Discord bot turns both into pings. See + [`APPROVAL_POLICY.md`](APPROVAL_POLICY.md). - **Review web/UI changes in a browser.** A human must inspect the rendered interface; AI review and reading the source code are not enough. diff --git a/APPROVAL_POLICY.md b/APPROVAL_POLICY.md new file mode 100644 index 00000000..347cce4b --- /dev/null +++ b/APPROVAL_POLICY.md @@ -0,0 +1,37 @@ +# Review routing + +Cursor's PR Routing agent has been requesting reviewers from commit +history. That pings @erikarenhill on Discord several times a day for +agent PRs he does not need to see, and it keeps doing so whether or +not he responds. + +This file overrides that reviewer-selection guidance. See +[PR Routing & Approval](https://cursor.com/docs/approval-agents). + +## Who to request + +Request a GitHub review only from people listed in `.github/CODEOWNERS` +for a path this PR actually changes. + +Do not pick reviewers from git blame, commit history, or "who else +collaborates here." + +Never request @erikarenhill. He is not a CODEOWNER. A human who +actually wants his eyes can still request him by hand. + +Do not @mention people in PR bodies or comments to get their +attention. The GitHub Discord bot turns those into pings too. + +## When not to request anyone + +If no CODEOWNERS path matches, request nobody. Web/UI changes need a +human looking at the rendered page (see AGENTS.md); that is not a +GitHub review request. + +Do not re-request a reviewer on later pushes of the same PR. Once is +enough. + +## Approvals + +This file does not authorise auto-approving PRs. CODEOWNERS review +and the web visual check stay as they are.