From 81a7aac8f777ef57a35c65b3206ef5eabb231727 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=86gir=20M=C3=A1ni=20Hauksson?= <54936225+sourcehawk@users.noreply.github.com> Date: Sun, 2 Aug 2026 20:19:17 +0200 Subject: [PATCH] test(examples): guard golden.Previewer type assertions The resource shape tests asserted res.(golden.Previewer) unchecked, so a resource that stopped implementing Previewer would panic instead of failing the assertion. The mutation tests in these same files already guard their concepts.MutationInspector casts, and docs/getting-started.md and docs/testing.md both document the guarded form, so the unchecked casts were the odd ones out. Co-Authored-By: Claude Opus 5 (1M context) --- examples/component-prerequisites/resources/configmap_test.go | 5 ++++- .../component-prerequisites/resources/deployment_test.go | 5 ++++- examples/custom-resource/resources/certificate_test.go | 5 ++++- examples/extraction-and-guards/resources/configmap_test.go | 5 ++++- examples/extraction-and-guards/resources/secret_test.go | 5 ++++- examples/grace-inconsistency/resources/deployment_test.go | 5 ++++- 6 files changed, 24 insertions(+), 6 deletions(-) diff --git a/examples/component-prerequisites/resources/configmap_test.go b/examples/component-prerequisites/resources/configmap_test.go index 84c99744..44267b11 100644 --- a/examples/component-prerequisites/resources/configmap_test.go +++ b/examples/component-prerequisites/resources/configmap_test.go @@ -34,6 +34,9 @@ func TestConfigMapShape(t *testing.T) { res, err := resources.NewConfigMapResource(owner) require.NoError(t, err) - golden.AssertYAML(t, "testdata/configmap.yaml", res.(golden.Previewer), + previewer, ok := res.(golden.Previewer) + require.True(t, ok) + + golden.AssertYAML(t, "testdata/configmap.yaml", previewer, golden.WithScheme(scheme), golden.Update(*update)) } diff --git a/examples/component-prerequisites/resources/deployment_test.go b/examples/component-prerequisites/resources/deployment_test.go index 396ddea5..57aaa448 100644 --- a/examples/component-prerequisites/resources/deployment_test.go +++ b/examples/component-prerequisites/resources/deployment_test.go @@ -62,7 +62,10 @@ func TestDeploymentShape(t *testing.T) { res, err := resources.NewDeploymentResource(owner) require.NoError(t, err) - golden.AssertYAML(t, tt.golden, res.(golden.Previewer), + previewer, ok := res.(golden.Previewer) + require.True(t, ok) + + golden.AssertYAML(t, tt.golden, previewer, golden.WithScheme(scheme), golden.Update(*update)) }) } diff --git a/examples/custom-resource/resources/certificate_test.go b/examples/custom-resource/resources/certificate_test.go index fed35b59..3928b312 100644 --- a/examples/custom-resource/resources/certificate_test.go +++ b/examples/custom-resource/resources/certificate_test.go @@ -49,7 +49,10 @@ func TestCertificateShape(t *testing.T) { res, err := resources.NewCertificateResource(testOwner()) require.NoError(t, err) - golden.AssertYAML(t, "testdata/certificate.yaml", res.(golden.Previewer), golden.Update(*update)) + previewer, ok := res.(golden.Previewer) + require.True(t, ok) + + golden.AssertYAML(t, "testdata/certificate.yaml", previewer, golden.Update(*update)) } // TestCertificateBaseShape pins the bare base object before any mutations. diff --git a/examples/extraction-and-guards/resources/configmap_test.go b/examples/extraction-and-guards/resources/configmap_test.go index 120c2609..917301a3 100644 --- a/examples/extraction-and-guards/resources/configmap_test.go +++ b/examples/extraction-and-guards/resources/configmap_test.go @@ -37,6 +37,9 @@ func TestConfigMapShape(t *testing.T) { res, err := resources.NewConfigMapResource(owner, dbHost) require.NoError(t, err) - golden.AssertYAML(t, "testdata/configmap.yaml", res.(golden.Previewer), + previewer, ok := res.(golden.Previewer) + require.True(t, ok) + + golden.AssertYAML(t, "testdata/configmap.yaml", previewer, golden.WithScheme(scheme), golden.Update(*update)) } diff --git a/examples/extraction-and-guards/resources/secret_test.go b/examples/extraction-and-guards/resources/secret_test.go index 7bcd027c..f0015bfe 100644 --- a/examples/extraction-and-guards/resources/secret_test.go +++ b/examples/extraction-and-guards/resources/secret_test.go @@ -26,6 +26,9 @@ func TestSecretShape(t *testing.T) { res, err := resources.NewSecretResource(owner, dbHost) require.NoError(t, err) - golden.AssertYAML(t, "testdata/secret.yaml", res.(golden.Previewer), + previewer, ok := res.(golden.Previewer) + require.True(t, ok) + + golden.AssertYAML(t, "testdata/secret.yaml", previewer, golden.WithScheme(scheme), golden.Update(*update)) } diff --git a/examples/grace-inconsistency/resources/deployment_test.go b/examples/grace-inconsistency/resources/deployment_test.go index 9e279a08..1b6e1204 100644 --- a/examples/grace-inconsistency/resources/deployment_test.go +++ b/examples/grace-inconsistency/resources/deployment_test.go @@ -38,6 +38,9 @@ func TestDeploymentShape(t *testing.T) { res, err := resources.NewDeploymentResource(owner) require.NoError(t, err) - golden.AssertYAML(t, "testdata/deployment.yaml", res.(golden.Previewer), + previewer, ok := res.(golden.Previewer) + require.True(t, ok) + + golden.AssertYAML(t, "testdata/deployment.yaml", previewer, golden.WithScheme(testScheme()), golden.Update(*update)) }