8mhz option

[macsimc]

Hi, Just to let you know that it does not work by default on a 8mhz pro mini,
It works if i change 2 to 1 when assigning to OCR1A

#define clockMultiplier 1 //2 for 16mhz
OCR1A = PPM_PULSE_LENGTH_uS * clockMultiplier;

[schinken]

the other parts, too I think?
https://github.com/schinken/PPMEncoder/blob/master/src/PPMEncoder.cpp#L65

[macsimc]

Yes, there are 3 places where the multiplier needs to be adjusted, i just added one as an example.
Thanks for the lib!

[schinken]

Can you send me a working example with 8mhz? I want to solve it using precompiler directives, but I need a working 8 mhz example

[macsimc]

Here we go, just replaced * 2 with a define which is 1 for 8mhz.

…

On Wed, May 3, 2023 at 2:55 PM Christopher Schirner < ***@***.***> wrote: Can you send me a working example with 8mhz? I want to solve it using precompiler directives, but I need a working 8 mhz example — Reply to this email directly, view it on GitHub <#5 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGAG5ODVMWHN6DDHZF674FTXEJBR5ANCNFSM6AAAAAAXUEXDUU> . You are receiving this because you authored the thread.Message ID: ***@***.***>

-- Catalin Macsim +40 740 075 154 http://www.macsim.ro #include "PPMEncoder.h" PPMEncoder ppmEncoder; void PPMEncoder::begin(uint8_t pin) { begin(pin, PPM_DEFAULT_CHANNELS, false); } void PPMEncoder::begin(uint8_t pin, uint8_t ch) { begin(pin, ch, false); } void PPMEncoder::begin(uint8_t pin, uint8_t ch, boolean inverted) { cli(); // Store on/off-State in variable to avoid another if in timing-critical interrupt onState = (inverted) ? HIGH : LOW; offState = (inverted) ? LOW : HIGH; pinMode(pin, OUTPUT); digitalWrite(pin, offState); state = true; elapsedUs = 0; currentChannel = 0; numChannels = ch; outputPin = pin; for (uint8_t ch = 0; ch < numChannels; ch++) { setChannelPercent(ch, 0); } TCCR1A = 0; OCR1A = 100; TCCR1B = (1 << WGM12) | (1 << CS11); TIMSK1 = (1 << OCIE1A); // enable timer compare interrupt sei(); } void PPMEncoder::setChannel(uint8_t channel, uint16_t value) { channels[channel] = constrain(value, PPMEncoder::MIN, PPMEncoder::MAX); } void PPMEncoder::setChannelPercent(uint8_t channel, uint8_t percent) { percent = constrain(percent, 0, 100); setChannel(channel, map(percent, 0, 100, PPMEncoder::MIN, PPMEncoder::MAX)); } #define clockMultiplier 1 void PPMEncoder::interrupt() { TCNT1 = 0; if (state) { digitalWrite(outputPin, onState); OCR1A = PPM_PULSE_LENGTH_uS * clockMultiplier; } else { digitalWrite(outputPin, offState); if (currentChannel >= numChannels) { currentChannel = 0; elapsedUs = elapsedUs + PPM_PULSE_LENGTH_uS; OCR1A = (PPM_FRAME_LENGTH_uS - elapsedUs) * clockMultiplier; elapsedUs = 0; } else { OCR1A = (channels[currentChannel] - PPM_PULSE_LENGTH_uS) * clockMultiplier; elapsedUs = elapsedUs + channels[currentChannel]; currentChannel++; } } state = !state; } ISR(TIMER1_COMPA_vect) { ppmEncoder.interrupt(); }