Skip to content

Incorrect keybindings appear in command palette when manual execution #53

Description

@yarakos95

Incorrect keybindings appear in command palette when manual execution

multicommand-commandPalette

I haven't defined such a keybinding. The command actually executed by the keybinding displayed here is sequence defined in multi-command.

To reproduce

To avoid the problem raised in # 16, the keybinding is defined as follows:

// keybindings.json
{
  "key": "alt+q",
  // ↑ This keybinding is displayed in command palette
  "command": "extension.multiCommand.execute",
  "args": {
    "command": "multiCommand.markdown.test"
  },
  "when": "editorTextFocus && editorLangId == markdown"
}

Keybindings for extension.multiCommand.execute are not defined.

To avoid this problem

This problem does not occur if you define the keybindings as follows:

// keybindings.json
{
  "key": "alt+q",
  "command": "multiCommand.markdown.test",
  "when": "editorTextFocus && editorLangId == markdown"
}

However, there are # 16 potential issues with this solution.

Alternatively, to really define keybinding for extension.multiCommand.execute. However, I don't want to define a keybinding because I think it's enough to call it from command palette.

Possible causes

VS Code misunderstands that even extension.multiCommand.execute including args defines a keybinding for extension.multiCommand.execute alone.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions