From d29412e66aadbaf63588e1000701315c12d3cdce Mon Sep 17 00:00:00 2001 From: bougyman's bot Date: Fri, 4 Sep 2026 21:36:11 -0400 Subject: [PATCH] refactor(git-hooks): consolidate hook path and remove ci/ validators Replace the two legacy ci/ validation scripts (conventional_commits.sh, validate_conventional_commit.sh) with direct calls to their counterparts under git-hooks/: git-hooks/validate-commit-range and git-hooks/validate-conventional-subject. - Delete ci/conventional_commits.sh and ci/validate_conventional_commit.sh - Update .github/workflows/ci.yaml to run ./git-hooks/validate-commit-range - Update app/usage-rules.md to reference git-hooks/validate-commit-range The hook installer (mix git_hooks), the hook wrappers (git-hooks/commit-msg and git-hooks/pre-push), the shared validators, and documentation were already updated by EXT-29 (db08f0e / 044459e). Co-Authored-By: Claude Sonnet 4.6 --- .github/workflows/ci.yaml | 2 +- app/usage-rules.md | 2 +- ci/conventional_commits.sh | 4 ---- ci/validate_conventional_commit.sh | 4 ---- 4 files changed, 2 insertions(+), 10 deletions(-) delete mode 100755 ci/conventional_commits.sh delete mode 100755 ci/validate_conventional_commit.sh diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 7d14fe6..1662960 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -159,4 +159,4 @@ jobs: - env: FETCH_BASE_REF: "true" - run: ./ci/conventional_commits.sh + run: ./git-hooks/validate-commit-range diff --git a/app/usage-rules.md b/app/usage-rules.md index 6a814e5..3f31ec9 100644 --- a/app/usage-rules.md +++ b/app/usage-rules.md @@ -14,7 +14,7 @@ formatting, static analysis, and tests) — run `mix setup` once per clone to activate both. - Enforced in CI across a whole PR's commit range by - `ci/conventional_commits.sh` (skips GitHub's own auto-generated + `git-hooks/validate-commit-range` (skips GitHub's own auto-generated update-branch merge commits). ## Dogfooding: use `lc`, not a Linear MCP server or skill diff --git a/ci/conventional_commits.sh b/ci/conventional_commits.sh deleted file mode 100755 index e9394f7..0000000 --- a/ci/conventional_commits.sh +++ /dev/null @@ -1,4 +0,0 @@ -#!/usr/bin/env bash -# Compatibility wrapper — the implementation has moved to git-hooks/validate-commit-range. -script_dir=$(cd "$(dirname "$0")" && pwd) -exec "$script_dir/../git-hooks/validate-commit-range" "$@" diff --git a/ci/validate_conventional_commit.sh b/ci/validate_conventional_commit.sh deleted file mode 100755 index 158528b..0000000 --- a/ci/validate_conventional_commit.sh +++ /dev/null @@ -1,4 +0,0 @@ -#!/usr/bin/env bash -# Compatibility wrapper — the implementation has moved to git-hooks/validate-conventional-subject. -script_dir=$(cd "$(dirname "$0")" && pwd) -exec "$script_dir/../git-hooks/validate-conventional-subject" "$@"