From 7a95144fbd3687439c288ee3db0deb02d1620add Mon Sep 17 00:00:00 2001
From: Adam Wright <adam.j.wright82@gmail.com>
Date: Sat, 5 Sep 2026 00:03:06 +0000
Subject: [PATCH] chore(viewport): drop the compare-form scaffold that was
 never written

`CompareFormComponent` is the Angular CLI's generated placeholder -- eleven
lines of TypeScript, an empty stylesheet, and a template reading
`<p>compare-form works!</p>`. It has been in the tree since the initial
commit, and it renders into every pathway browser page inside a panel that
can never open: the panel is gated on `dropdown() === 'compare'`, and
nothing anywhere sets that state.

It cost me twenty minutes today. Chasing whether the toolbar's Compare
button worked, I found a component named compare-form, a dropdown state
called 'compare', and no way to reach either -- which reads like a broken
feature rather than an unfinished one. Comparing against a disease variant
is the Compare button in the toolbar, and it works: it opens a menu of the
disease variants and navigates. That is the whole feature.

So the state is narrowed to 'analysis' | null, the panel is gone, and the
scaffold with it. Verified on beta: the Compare menu still lists "Defective
Intrinsic Pathway for Apoptosis", Analyze still opens its form, no
cr-compare-form left in the DOM, no console errors.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
---
 .../viewport/compare-form/compare-form.component.html |  1 -
 .../viewport/compare-form/compare-form.component.scss |  0
 .../viewport/compare-form/compare-form.component.ts   | 11 -----------
 .../src/app/viewport/viewport.component.html          |  3 ---
 .../src/app/viewport/viewport.component.ts            | 10 +++++++---
 5 files changed, 7 insertions(+), 18 deletions(-)
 delete mode 100644 projects/pathway-browser/src/app/viewport/compare-form/compare-form.component.html
 delete mode 100644 projects/pathway-browser/src/app/viewport/compare-form/compare-form.component.scss
 delete mode 100644 projects/pathway-browser/src/app/viewport/compare-form/compare-form.component.ts

diff --git a/projects/pathway-browser/src/app/viewport/compare-form/compare-form.component.html b/projects/pathway-browser/src/app/viewport/compare-form/compare-form.component.html
deleted file mode 100644
index 812abe26..00000000
--- a/projects/pathway-browser/src/app/viewport/compare-form/compare-form.component.html
+++ /dev/null
@@ -1 +0,0 @@
-<p>compare-form works!</p>
diff --git a/projects/pathway-browser/src/app/viewport/compare-form/compare-form.component.scss b/projects/pathway-browser/src/app/viewport/compare-form/compare-form.component.scss
deleted file mode 100644
index e69de29b..00000000
diff --git a/projects/pathway-browser/src/app/viewport/compare-form/compare-form.component.ts b/projects/pathway-browser/src/app/viewport/compare-form/compare-form.component.ts
deleted file mode 100644
index 81ea311e..00000000
--- a/projects/pathway-browser/src/app/viewport/compare-form/compare-form.component.ts
+++ /dev/null
@@ -1,11 +0,0 @@
-import { Component, output } from '@angular/core';
-
-@Component({
-  selector: 'cr-compare-form',
-  imports: [],
-  templateUrl: './compare-form.component.html',
-  styleUrl: './compare-form.component.scss',
-})
-export class CompareFormComponent {
-  close = output<{ status: 'finished' | 'premature' }>();
-}
diff --git a/projects/pathway-browser/src/app/viewport/viewport.component.html b/projects/pathway-browser/src/app/viewport/viewport.component.html
index ea5b2423..0a1ea914 100644
--- a/projects/pathway-browser/src/app/viewport/viewport.component.html
+++ b/projects/pathway-browser/src/app/viewport/viewport.component.html
@@ -248,9 +248,6 @@
               <div class="dropdown" [class.open]="dropdown() === 'analysis'">
                 <cr-analysis-form (close)="closeAnalysis()" [status]="analysisStatus" />
               </div>
-              <div class="dropdown" [class.open]="dropdown() === 'compare'">
-                <cr-compare-form (close)="dropdown.set(null)" />
-              </div>
             </as-split-area>
 
             <div
diff --git a/projects/pathway-browser/src/app/viewport/viewport.component.ts b/projects/pathway-browser/src/app/viewport/viewport.component.ts
index 82d1383b..00c22c66 100644
--- a/projects/pathway-browser/src/app/viewport/viewport.component.ts
+++ b/projects/pathway-browser/src/app/viewport/viewport.component.ts
@@ -48,7 +48,6 @@ import { MatMenu, MatMenuItem, MatMenuTrigger } from '@angular/material/menu';
 import { MatButton, MatIconButton } from '@angular/material/button';
 import { NgClass } from '@angular/common';
 import { AnalysisFormComponent } from './analysis-form/analysis-form.component';
-import { CompareFormComponent } from './compare-form/compare-form.component';
 import { FormsModule } from '@angular/forms';
 import { MatRadioButton, MatRadioGroup } from '@angular/material/radio';
 
@@ -87,7 +86,6 @@ const DROPDOWN_DURATION = 500;
     ReacfoamComponent,
     DetailsComponent,
     AnalysisFormComponent,
-    CompareFormComponent,
   ],
 })
 @UntilDestroy()
@@ -168,7 +166,13 @@ export class ViewportComponent implements AfterViewInit {
   dropdownDuration = DROPDOWN_DURATION;
   readonly isCurator = IS_CURATOR;
 
-  dropdown = signal<'analysis' | 'compare' | null>(null);
+  // Only the analysis form opens here. There was a 'compare' state too, with a
+  // panel of its own in the template, and nothing anywhere set it -- the form
+  // behind it was the CLI's `<p>compare-form works!</p>` scaffold, shipped in
+  // the initial commit and never written. Comparing against a disease variant
+  // is the Compare button in the toolbar, which navigates rather than opening a
+  // panel.
+  dropdown = signal<'analysis' | null>(null);
 
   toggleAnalysis() {
     this.dropdown.set(this.dropdown() ? null : 'analysis');