From dc597a70490c7fc5e990115e170215d5532a21bb Mon Sep 17 00:00:00 2001 From: Paul Praet <3198728+praetp@users.noreply.github.com> Date: Thu, 30 Jul 2026 20:20:11 +0200 Subject: [PATCH 1/2] Rename eclipse_magic.lua to eclipse.lua Magic Lantern's Lua loader only picks up scripts whose base filename fits in the 8.3 convention (up to 8 characters before the extension). With the previous 13-character name, the script silently fails to appear in the Scripts menu on affected ML builds/bodies, while other shorter-named .lua scripts on the same card show up normally. Renaming to eclipse.lua makes the script discoverable out of the box, with no user-side rename step required. --- eclipse_magic.lua => eclipse.lua | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename eclipse_magic.lua => eclipse.lua (100%) diff --git a/eclipse_magic.lua b/eclipse.lua similarity index 100% rename from eclipse_magic.lua rename to eclipse.lua From bb0dd6e01b6a5d24c414ba277e50eecb037ab3f6 Mon Sep 17 00:00:00 2001 From: Paul Praet <3198728+praetp@users.noreply.github.com> Date: Sun, 9 Aug 2026 14:13:34 +0200 Subject: [PATCH 2/2] Fix inverted TestBeepNoShutter contact time branches The two branches setting c1-c4 were the wrong way round relative to the flag that selects them. get_cur_secs() subtracts the script start time when TestBeepNoShutter is 1, so that branch needs the short offsets. It held the Esterbrook wall-clock times instead, which were read as "start in 10 hours 23 minutes". Worse, real runs (TestBeepNoShutter = 0) took the else branch and so got 00:01:00 - 00:09:00, read as wall-clock times just after midnight. Every phase guard in do_partial(), do_c2max(), do_max() and do_maxc3() saw them as long past, so all five phases were skipped, the script logged a normal exit and no images were taken at all. Swap the branch bodies, each keeping its own comment, and document which way the times are interpreted. Co-Authored-By: Claude Opus 5 --- eclipse.lua | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/eclipse.lua b/eclipse.lua index a2d2d4b..9c1e95c 100644 --- a/eclipse.lua +++ b/eclipse.lua @@ -90,19 +90,24 @@ LoggingFile = nil -- times are the same. Make sure the times are correct for your location, and that your camera -- is accurately set to GPS time. -- +-- Note that the two branches below are not interchangeable. When TestBeepNoShutter +-- is 1, get_cur_secs() subtracts the script start time, so the contact times are read +-- as an offset from when the script is run. Otherwise they are read as wall-clock +-- times from the camera's clock. +-- if ( TestBeepNoShutter == 1 ) then - -- Esterbrook: 10:23:32 11:44:37 11:46:53 13:11:42 - c1.hr = 10; c1.min = 23; c1.sec = 32 - c2.hr = 11; c2.min = 44; c2.sec = 37; - c3.hr = 11; c3.min = 46; c3.sec = 53; - c4.hr = 13; c4.min = 11; c4.sec = 42; -else -- Testing: c1.hr = 0; c1.min = 1; c1.sec = 00; c2.hr = 0; c2.min = 4; c2.sec = 00; c3.hr = 0; c3.min = 6; c3.sec = 20; c4.hr = 0; c4.min = 9; c4.sec = 00; +else + -- Esterbrook: 10:23:32 11:44:37 11:46:53 13:11:42 + c1.hr = 10; c1.min = 23; c1.sec = 32 + c2.hr = 11; c2.min = 44; c2.sec = 37; + c3.hr = 11; c3.min = 46; c3.sec = 53; + c4.hr = 13; c4.min = 11; c4.sec = 42; end