Merge "Fix limit list --service passing object instead of ID"

Author: Zuul

openstackclient/identity/v3/limit.py

@@ -171,7 +171,7 @@ def take_action(
         if parsed_args.service:
             kwargs["service_id"] = common_utils.find_service_sdk(
                 identity_client, parsed_args.service
-            )
+            ).id
 
         if parsed_args.region:
             kwargs["region_id"] = identity_client.get_region(

openstackclient/tests/unit/identity/v3/test_limit.py

@@ -450,3 +450,44 @@ def test_limit_list(self):
             ),
         )
         self.assertEqual(datalist, tuple(data))
+
+    def test_limit_list_with_service_filter(self):
+        self.identity_sdk_client.find_service.return_value = self.service
+
+        arglist = [
+            '--service',
+            self.service.name,
+        ]
+        verifylist = [
+            ('service', self.service.name),
+        ]
+        parsed_args = self.check_parser(self.cmd, arglist, verifylist)
+
+        columns, data = self.cmd.take_action(parsed_args)
+
+        self.identity_sdk_client.limits.assert_called_with(
+            service_id=self.service.id,
+        )
+
+        collist = (
+            'ID',
+            'Project ID',
+            'Service ID',
+            'Resource Name',
+            'Resource Limit',
+            'Description',
+            'Region ID',
+        )
+        self.assertEqual(collist, columns)
+        datalist = (
+            (
+                self.limit.id,
+                self.project.id,
+                self.service.id,
+                self.limit.resource_name,
+                self.limit.resource_limit,
+                None,
+                None,
+            ),
+        )
+        self.assertEqual(datalist, tuple(data))