Allow removing deleted projects from flavor access list

When a project has been deleted from Keystone, `flavor unset --project`
fails because find_project_id_sdk() validates the project existence
against Keystone before calling Nova's removeTenantAccess API.

Pass validate_actor_existence=False so that when the project is not
found in Keystone, the raw project ID is passed through to Nova, which
already handles deleted projects gracefully since the fix for
bug #1980845.

Closes-Bug: #2099702

Assisted-By: Claude-Code opus 4.6
Change-Id: Ida1608a0d8753e555206da56312a85536e50ba5b
Signed-off-by: René Ribaud <rene.ribaud@gmail.com>

Author: uggla

openstackclient/compute/v2/flavor.py

@@ -633,6 +633,7 @@ def take_action(self, parsed_args: argparse.Namespace) -> None:
                     identity_client,
                     parsed_args.project,
                     parsed_args.project_domain,
+                    validate_actor_existence=False,
                 )
                 compute_client.flavor_remove_tenant_access(
                     flavor.id, project_id

openstackclient/tests/unit/compute/v2/test_flavor.py

@@ -1223,7 +1223,6 @@ def test_flavor_unset_with_unexist_flavor(self):
         )
 
     def test_flavor_unset_project_deleted_project(self):
-        # Simulate a project that has been deleted from Keystone
         self.identity_sdk_client.find_project.side_effect = [
             sdk_exceptions.ResourceNotFound()
         ]
@@ -1240,18 +1239,13 @@ def test_flavor_unset_project_deleted_project(self):
         ]
         parsed_args = self.check_parser(self.cmd, arglist, verifylist)
 
-        # TODO(bug #2099702): This should succeed. When removing a project
-        # from a flavor's access list, the project may no longer exist in
-        # Keystone (deleted tenant). The command should pass the raw project
-        # ID through to Nova's removeTenantAccess API, which already handles
-        # this case since the fix for bug #1980845. Instead, the command
-        # fails because find_project_id_sdk() validates the project against
-        # Keystone with validate_actor_existence=True (the default) and
-        # raises CommandError when it doesn't exist.
-        self.assertRaises(
-            exceptions.CommandError, self.cmd.take_action, parsed_args
+        result = self.cmd.take_action(parsed_args)
+        self.assertIsNone(result)
+
+        self.compute_client.flavor_remove_tenant_access.assert_called_with(
+            self.flavor.id,
+            deleted_project_id,
         )
-        self.compute_client.flavor_remove_tenant_access.assert_not_called()
 
     def test_flavor_unset_nothing(self):
         arglist = [