From 55b2599150768c22ab62ca09ecea5c937026139a Mon Sep 17 00:00:00 2001 From: mawat-odoo Date: Tue, 15 Sep 2026 13:22:31 +0200 Subject: [PATCH 01/10] [ADD] estate: create initial module structure and manifest Initialize the estate module with its basic directory structure and manifest file as required for the technical onboarding training. task-6573564 --- .gitignore | 55 +++++++++++++++++++++++++++++++++++++++--- estate/__init__.py | 0 estate/__manifest__.py | 8 ++++++ 3 files changed, 60 insertions(+), 3 deletions(-) create mode 100644 estate/__init__.py create mode 100644 estate/__manifest__.py diff --git a/.gitignore b/.gitignore index b6e47617de1..1461e9611c2 100644 --- a/.gitignore +++ b/.gitignore @@ -1,3 +1,9 @@ +# Created by https://www.toptal.com/developers/gitignore/api/python,odoo +# Edit at https://www.toptal.com/developers/gitignore?templates=python,odoo + +#!! ERROR: odoo is undefined. Use list command to see defined gitignore types !!# + +### Python ### # Byte-compiled / optimized / DLL files __pycache__/ *.py[cod] @@ -20,7 +26,6 @@ parts/ sdist/ var/ wheels/ -pip-wheel-metadata/ share/python-wheels/ *.egg-info/ .installed.cfg @@ -50,6 +55,7 @@ coverage.xml *.py,cover .hypothesis/ .pytest_cache/ +cover/ # Translations *.mo @@ -72,6 +78,7 @@ instance/ docs/_build/ # PyBuilder +.pybuilder/ target/ # Jupyter Notebook @@ -82,7 +89,9 @@ profile_default/ ipython_config.py # pyenv -.python-version +# For a library or package, you might want to ignore these files since the code is +# intended to run in multiple environments; otherwise, check them in: +# .python-version # pipenv # According to pypa/pipenv#598, it is recommended to include Pipfile.lock in version control. @@ -91,7 +100,22 @@ ipython_config.py # install all needed dependencies. #Pipfile.lock -# PEP 582; used by e.g. github.com/David-OConnor/pyflow +# poetry +# Similar to Pipfile.lock, it is generally recommended to include poetry.lock in version control. +# This is especially recommended for binary packages to ensure reproducibility, and is more +# commonly ignored for libraries. +# https://python-poetry.org/docs/basic-usage/#commit-your-poetrylock-file-to-version-control +#poetry.lock + +# pdm +# Similar to Pipfile.lock, it is generally recommended to include pdm.lock in version control. +#pdm.lock +# pdm stores project-wide configurations in .pdm.toml, but it is recommended to not include it +# in version control. +# https://pdm.fming.dev/#use-with-ide +.pdm.toml + +# PEP 582; used by e.g. github.com/David-OConnor/pyflow and github.com/pdm-project/pdm __pypackages__/ # Celery stuff @@ -127,3 +151,28 @@ dmypy.json # Pyre type checker .pyre/ + +# pytype static type analyzer +.pytype/ + +# Cython debug symbols +cython_debug/ + +# PyCharm +# JetBrains specific template is maintained in a separate JetBrains.gitignore that can +# be found at https://github.com/github/gitignore/blob/main/Global/JetBrains.gitignore +# and can be added to the global gitignore or merged into this file. For a more nuclear +# option (not recommended) you can uncomment the following to ignore the entire idea folder. +#.idea/ + +### Python Patch ### +# Poetry local configuration file - https://python-poetry.org/docs/configuration/#local-configuration +poetry.toml + +# ruff +.ruff_cache/ + +# LSP config files +pyrightconfig.json + +# End of https://www.toptal.com/developers/gitignore/api/python,odoo diff --git a/estate/__init__.py b/estate/__init__.py new file mode 100644 index 00000000000..e69de29bb2d diff --git a/estate/__manifest__.py b/estate/__manifest__.py new file mode 100644 index 00000000000..fc47b3ba410 --- /dev/null +++ b/estate/__manifest__.py @@ -0,0 +1,8 @@ +# __manifest__.py +{ # noqa: B018 + "author": "mawat", + "name": "estate", + "depends": ["base"], + "application": True, + "license": "LGPL-3", +} From 3e53ed6cd708ebf82a0c38357a95328b5d4f4fa2 Mon Sep 17 00:00:00 2001 From: mawat-odoo Date: Wed, 16 Sep 2026 09:22:49 +0200 Subject: [PATCH 02/10] [ADD] estate: create estate.property model with basic fields - Create models package and __init__.py files - Define estate.property model with basic fields: * name, description, postcode * date_availability, expected_price, selling_price * bedrooms, living_area, facades, garage * garden, garden_area, garden_orientation task-6573564 --- estate/__init__.py | 1 + estate/models/__init__.py | 1 + estate/models/estate_property.py | 23 +++++++++++++++++++++++ 3 files changed, 25 insertions(+) create mode 100644 estate/models/__init__.py create mode 100644 estate/models/estate_property.py diff --git a/estate/__init__.py b/estate/__init__.py index e69de29bb2d..0650744f6bc 100644 --- a/estate/__init__.py +++ b/estate/__init__.py @@ -0,0 +1 @@ +from . import models diff --git a/estate/models/__init__.py b/estate/models/__init__.py new file mode 100644 index 00000000000..5e1963c9d2f --- /dev/null +++ b/estate/models/__init__.py @@ -0,0 +1 @@ +from . import estate_property diff --git a/estate/models/estate_property.py b/estate/models/estate_property.py new file mode 100644 index 00000000000..7deaa93f21e --- /dev/null +++ b/estate/models/estate_property.py @@ -0,0 +1,23 @@ +from odoo import fields, models + + +class EstateProperty(models.Model): + _name = "estate.property" + _description = "Estate property model" + + name = fields.Char(required=True) + description = fields.Text() + postcode = fields.Char() + date_availibility = fields.Date() + expected_price = fields.Float(required=True) + selling_price = fields.Float() + bedrooms = fields.Integer() + living_area = fields.Integer() + facades = fields.Integer() + garage = fields.Boolean() + garden = fields.Boolean() + garden_area = fields.Integer() + garden_orientation = fields.Selection( + string='Type', + selection=[('North', 'North'), ('South', 'South'), ('East', 'East'), ('West', 'West')] + ) From 8e7aed27792402db595a6264526e853278d8085a Mon Sep 17 00:00:00 2001 From: mawat-odoo Date: Wed, 16 Sep 2026 09:56:39 +0200 Subject: [PATCH 03/10] [FIX] remove environmental gitignore file --- .gitignore | 178 ----------------------------------------------------- 1 file changed, 178 deletions(-) delete mode 100644 .gitignore diff --git a/.gitignore b/.gitignore deleted file mode 100644 index 1461e9611c2..00000000000 --- a/.gitignore +++ /dev/null @@ -1,178 +0,0 @@ -# Created by https://www.toptal.com/developers/gitignore/api/python,odoo -# Edit at https://www.toptal.com/developers/gitignore?templates=python,odoo - -#!! ERROR: odoo is undefined. Use list command to see defined gitignore types !!# - -### Python ### -# Byte-compiled / optimized / DLL files -__pycache__/ -*.py[cod] -*$py.class - -# C extensions -*.so - -# Distribution / packaging -.Python -build/ -develop-eggs/ -dist/ -downloads/ -eggs/ -.eggs/ -lib/ -lib64/ -parts/ -sdist/ -var/ -wheels/ -share/python-wheels/ -*.egg-info/ -.installed.cfg -*.egg -MANIFEST - -# PyInstaller -# Usually these files are written by a python script from a template -# before PyInstaller builds the exe, so as to inject date/other infos into it. -*.manifest -*.spec - -# Installer logs -pip-log.txt -pip-delete-this-directory.txt - -# Unit test / coverage reports -htmlcov/ -.tox/ -.nox/ -.coverage -.coverage.* -.cache -nosetests.xml -coverage.xml -*.cover -*.py,cover -.hypothesis/ -.pytest_cache/ -cover/ - -# Translations -*.mo -*.pot - -# Django stuff: -*.log -local_settings.py -db.sqlite3 -db.sqlite3-journal - -# Flask stuff: -instance/ -.webassets-cache - -# Scrapy stuff: -.scrapy - -# Sphinx documentation -docs/_build/ - -# PyBuilder -.pybuilder/ -target/ - -# Jupyter Notebook -.ipynb_checkpoints - -# IPython -profile_default/ -ipython_config.py - -# pyenv -# For a library or package, you might want to ignore these files since the code is -# intended to run in multiple environments; otherwise, check them in: -# .python-version - -# pipenv -# According to pypa/pipenv#598, it is recommended to include Pipfile.lock in version control. -# However, in case of collaboration, if having platform-specific dependencies or dependencies -# having no cross-platform support, pipenv may install dependencies that don't work, or not -# install all needed dependencies. -#Pipfile.lock - -# poetry -# Similar to Pipfile.lock, it is generally recommended to include poetry.lock in version control. -# This is especially recommended for binary packages to ensure reproducibility, and is more -# commonly ignored for libraries. -# https://python-poetry.org/docs/basic-usage/#commit-your-poetrylock-file-to-version-control -#poetry.lock - -# pdm -# Similar to Pipfile.lock, it is generally recommended to include pdm.lock in version control. -#pdm.lock -# pdm stores project-wide configurations in .pdm.toml, but it is recommended to not include it -# in version control. -# https://pdm.fming.dev/#use-with-ide -.pdm.toml - -# PEP 582; used by e.g. github.com/David-OConnor/pyflow and github.com/pdm-project/pdm -__pypackages__/ - -# Celery stuff -celerybeat-schedule -celerybeat.pid - -# SageMath parsed files -*.sage.py - -# Environments -.env -.venv -env/ -venv/ -ENV/ -env.bak/ -venv.bak/ - -# Spyder project settings -.spyderproject -.spyproject - -# Rope project settings -.ropeproject - -# mkdocs documentation -/site - -# mypy -.mypy_cache/ -.dmypy.json -dmypy.json - -# Pyre type checker -.pyre/ - -# pytype static type analyzer -.pytype/ - -# Cython debug symbols -cython_debug/ - -# PyCharm -# JetBrains specific template is maintained in a separate JetBrains.gitignore that can -# be found at https://github.com/github/gitignore/blob/main/Global/JetBrains.gitignore -# and can be added to the global gitignore or merged into this file. For a more nuclear -# option (not recommended) you can uncomment the following to ignore the entire idea folder. -#.idea/ - -### Python Patch ### -# Poetry local configuration file - https://python-poetry.org/docs/configuration/#local-configuration -poetry.toml - -# ruff -.ruff_cache/ - -# LSP config files -pyrightconfig.json - -# End of https://www.toptal.com/developers/gitignore/api/python,odoo From 9f2dbc6959008e4fb008a14603e5e5bd99b6cd86 Mon Sep 17 00:00:00 2001 From: mawat-odoo Date: Wed, 16 Sep 2026 11:01:53 +0200 Subject: [PATCH 04/10] [ADD] estate: add access rights for estate.property model - Add security/ir.model.access.csv with full permissions for internal users - Declare security file in __manifest__.py task-6573564 --- estate/__manifest__.py | 3 +++ estate/security/ir.model.access.csv | 2 ++ 2 files changed, 5 insertions(+) create mode 100644 estate/security/ir.model.access.csv diff --git a/estate/__manifest__.py b/estate/__manifest__.py index fc47b3ba410..ec3e036aa21 100644 --- a/estate/__manifest__.py +++ b/estate/__manifest__.py @@ -5,4 +5,7 @@ "depends": ["base"], "application": True, "license": "LGPL-3", + "data": [ + "security/ir.model.access.csv", + ], } diff --git a/estate/security/ir.model.access.csv b/estate/security/ir.model.access.csv new file mode 100644 index 00000000000..ed7060e60a7 --- /dev/null +++ b/estate/security/ir.model.access.csv @@ -0,0 +1,2 @@ +id,name,model_id/id,group_id/id,perm_read,perm_write,perm_create,perm_unlink +access_estate_property,estate_property,model_estate_property,base.group_user,1,1,1,1 From 32a2e2520ac7933ffe397f9eb233c706a2dfae18 Mon Sep 17 00:00:00 2001 From: mawat-odoo Date: Thu, 17 Sep 2026 00:40:56 +0200 Subject: [PATCH 05/10] [ADD] estate: add UI action, menus, field attributes, and reserved fields - Create estate_property_views.xml with act_window for estate.property model - Create estate_menus.xml with 3-level menu hierarchy - Register XML files sequentially in __manifest__.py - Set selling_price as readonly and non-copyable - Prevent copy on date_availability and set default to 3 months from today - Set default bedrooms to 2 - Add reserved active field (Boolean) with default=True - Add required state field (Selection: New, Offer Received, Offer Accepted, Sold, Cancelled) with default='new' and copy=False task-6573564 --- estate/__manifest__.py | 2 ++ estate/models/estate_property.py | 17 ++++++++++++++--- estate/views/estate_menus.xml | 8 ++++++++ estate/views/estate_property_views.xml | 8 ++++++++ 4 files changed, 32 insertions(+), 3 deletions(-) create mode 100644 estate/views/estate_menus.xml create mode 100644 estate/views/estate_property_views.xml diff --git a/estate/__manifest__.py b/estate/__manifest__.py index ec3e036aa21..05e007850c5 100644 --- a/estate/__manifest__.py +++ b/estate/__manifest__.py @@ -7,5 +7,7 @@ "license": "LGPL-3", "data": [ "security/ir.model.access.csv", + "views/estate_property_views.xml", + "views/estate_menus.xml" ], } diff --git a/estate/models/estate_property.py b/estate/models/estate_property.py index 7deaa93f21e..136a0598222 100644 --- a/estate/models/estate_property.py +++ b/estate/models/estate_property.py @@ -1,3 +1,5 @@ +from odoo.tools import date_utils + from odoo import fields, models @@ -5,13 +7,22 @@ class EstateProperty(models.Model): _name = "estate.property" _description = "Estate property model" + active = fields.Boolean('Active', default=True) + state = fields.Selection([ + ('new', 'New'), + ('offer received', 'Offer Received'), + ('offer accepted', 'Offer Accepted'), + ('sold', 'Sold'), + ('cancelled', 'Cancelled') + ], string='Status', default='new', required=True, copy=False) + name = fields.Char(required=True) description = fields.Text() postcode = fields.Char() - date_availibility = fields.Date() + date_availibility = fields.Date(copy=False, default=lambda self: date_utils.add(fields.Date.today(), months=3)) expected_price = fields.Float(required=True) - selling_price = fields.Float() - bedrooms = fields.Integer() + selling_price = fields.Float(readonly=True, copy=False) + bedrooms = fields.Integer(default=2) living_area = fields.Integer() facades = fields.Integer() garage = fields.Boolean() diff --git a/estate/views/estate_menus.xml b/estate/views/estate_menus.xml new file mode 100644 index 00000000000..f12c6192cf8 --- /dev/null +++ b/estate/views/estate_menus.xml @@ -0,0 +1,8 @@ + + + + + + + + diff --git a/estate/views/estate_property_views.xml b/estate/views/estate_property_views.xml new file mode 100644 index 00000000000..1d2a3aaa4cd --- /dev/null +++ b/estate/views/estate_property_views.xml @@ -0,0 +1,8 @@ + + + + Properties + estate.property + list,form + + From af5fe3c8ae0ae37024b3f4d10de39ef1c34556d7 Mon Sep 17 00:00:00 2001 From: mawat-odoo Date: Thu, 17 Sep 2026 03:06:27 +0200 Subject: [PATCH 06/10] [FIX] estate: fix state selection key formatting Task ID: 6573564 --- estate/models/estate_property.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/estate/models/estate_property.py b/estate/models/estate_property.py index 136a0598222..30aebcd1877 100644 --- a/estate/models/estate_property.py +++ b/estate/models/estate_property.py @@ -10,8 +10,8 @@ class EstateProperty(models.Model): active = fields.Boolean('Active', default=True) state = fields.Selection([ ('new', 'New'), - ('offer received', 'Offer Received'), - ('offer accepted', 'Offer Accepted'), + ('offer_received', 'Offer Received'), + ('offer_accepted', 'Offer Accepted'), ('sold', 'Sold'), ('cancelled', 'Cancelled') ], string='Status', default='new', required=True, copy=False) @@ -19,7 +19,7 @@ class EstateProperty(models.Model): name = fields.Char(required=True) description = fields.Text() postcode = fields.Char() - date_availibility = fields.Date(copy=False, default=lambda self: date_utils.add(fields.Date.today(), months=3)) + date_availability = fields.Date(copy=False, default=lambda self: date_utils.add(fields.Date.today(), months=3)) expected_price = fields.Float(required=True) selling_price = fields.Float(readonly=True, copy=False) bedrooms = fields.Integer(default=2) From 74647bf6b7c926c835d075258bbbb197c9aad668 Mon Sep 17 00:00:00 2001 From: mawat-odoo Date: Thu, 17 Sep 2026 03:06:49 +0200 Subject: [PATCH 07/10] [ADD] estate: add basic property views Add list, form, and search views for estate.property model. Search view includes custom filter for available properties and grouping by postcode. - Add list view for property model - Add form view with sheet, group, and notebook tags - Add search view with domain filter and group_by context Task ID: 6573564 --- estate/views/estate_property_views.xml | 76 ++++++++++++++++++++++++++ 1 file changed, 76 insertions(+) diff --git a/estate/views/estate_property_views.xml b/estate/views/estate_property_views.xml index 1d2a3aaa4cd..cfe148e2626 100644 --- a/estate/views/estate_property_views.xml +++ b/estate/views/estate_property_views.xml @@ -1,5 +1,81 @@ + + estate.property.search + estate.property + + + + + + + + + + + + + + + + + + + estate.property.form + estate.property + +
+ +

+ +

+ + + + + + + + + + + + + + + + + + + + + + + + + +
+ + + + + estate.property.list + estate.property + + + + + + + + + + + + + Properties estate.property From 8a0878c9c36895479da6cfe4675beaa823feb2d4 Mon Sep 17 00:00:00 2001 From: mawat-odoo Date: Thu, 17 Sep 2026 14:00:39 +0200 Subject: [PATCH 08/10] [IMP] estate: add relational models and fields Add estate.property.type, estate.property.tag, and estate.property.offer models along with their actions and views to handle property classification and offers. - Create estate.property.type model with menu, action, and views - Create estate.property.tag model with action and list/form views - Create estate.property.offer model with list and form views - Add Many2one links (property_type_id, buyer_id, user_id) to estate.property - Add Many2many link (tag_ids) to estate.property - Add One2many link (offer_ids) to estate.property Task ID: 6573564 --- estate/models/estate_property_offer.py | 14 +++++++++ estate/models/estate_property_tag.py | 7 +++++ estate/models/estate_property_type.py | 7 +++++ estate/views/estate_property_offer_views.xml | 33 ++++++++++++++++++++ estate/views/estate_property_tag_views.xml | 22 +++++++++++++ estate/views/estate_property_type_views.xml | 22 +++++++++++++ 6 files changed, 105 insertions(+) create mode 100644 estate/models/estate_property_offer.py create mode 100644 estate/models/estate_property_tag.py create mode 100644 estate/models/estate_property_type.py create mode 100644 estate/views/estate_property_offer_views.xml create mode 100644 estate/views/estate_property_tag_views.xml create mode 100644 estate/views/estate_property_type_views.xml diff --git a/estate/models/estate_property_offer.py b/estate/models/estate_property_offer.py new file mode 100644 index 00000000000..6f553cb87e2 --- /dev/null +++ b/estate/models/estate_property_offer.py @@ -0,0 +1,14 @@ +from odoo import fields, models + + +class EstatePropertyOffer(models.Model): + _name = "estate.property.offer" + _description = "Estate property offer model" + + price = fields.Float() + status = fields.Selection([ + ('accepted', 'Accepted'), + ('refused', 'Refused') + ], copy=False) + partner_id = fields.Many2one("res.partner", required=True, string="Partner") + property_id = fields.Many2one("estate.property", required=True) diff --git a/estate/models/estate_property_tag.py b/estate/models/estate_property_tag.py new file mode 100644 index 00000000000..47210e31c43 --- /dev/null +++ b/estate/models/estate_property_tag.py @@ -0,0 +1,7 @@ +from odoo import fields, models + +class EstatePropertyTag(models.Model): + _name = "estate.property.tag" + _description = "Estate property tag model" + + name = fields.Char(required=True) diff --git a/estate/models/estate_property_type.py b/estate/models/estate_property_type.py new file mode 100644 index 00000000000..8a49e97c224 --- /dev/null +++ b/estate/models/estate_property_type.py @@ -0,0 +1,7 @@ +from odoo import fields, models + +class EstatePropertyType(models.Model): + _name = "estate.property.type" + _description = "Estate property type model" + + name = fields.Char(required=True) diff --git a/estate/views/estate_property_offer_views.xml b/estate/views/estate_property_offer_views.xml new file mode 100644 index 00000000000..276aa7570b7 --- /dev/null +++ b/estate/views/estate_property_offer_views.xml @@ -0,0 +1,33 @@ + + + + estate.property.offer.form + estate.property.offer + +
+ +

+ +

+ + + + + + +
+ + + + + estate.property.offer.list + estate.property.offer + + + + + + + + + diff --git a/estate/views/estate_property_tag_views.xml b/estate/views/estate_property_tag_views.xml new file mode 100644 index 00000000000..21e835ac5bd --- /dev/null +++ b/estate/views/estate_property_tag_views.xml @@ -0,0 +1,22 @@ + + + + estate.property.tag.form + estate.property.tag + +
+ +

+ +

+ +
+ + + + + Property Tags + estate.property.tag + list,form + + diff --git a/estate/views/estate_property_type_views.xml b/estate/views/estate_property_type_views.xml new file mode 100644 index 00000000000..6879b9b68e9 --- /dev/null +++ b/estate/views/estate_property_type_views.xml @@ -0,0 +1,22 @@ + + + + estate.property.type.form + estate.property.type + +
+ +

+ +

+ +
+ + + + + Property Types + estate.property.type + list,form + + From c292f3643c0c510ced52020542092b7ae00c5cc7 Mon Sep 17 00:00:00 2001 From: mawat-odoo Date: Thu, 17 Sep 2026 14:00:52 +0200 Subject: [PATCH 09/10] [FIX] estate: apply code review feedback and guidelines Address code review comments by improving field definitions, using lowercase selection keys, simplifying domains, and fixing PEP 8 blank line rules (E302). - Fix E302 missing blank lines before class declarations - Remove unused empty line and refine date_utils import in estate_property.py - Convert selection keys to lowercase for garden_orientation - Simplify domain filter syntax using in operator in estate_property_views.xml - Move field string labels to Python definitions - Fix typo in menu identifier estate_first_level_menu - Change manifest author to Odoo S.A. Task ID: 6573564 --- estate/__manifest__.py | 5 +++- estate/models/__init__.py | 3 +++ estate/models/estate_property.py | 25 ++++++++++++------ estate/security/ir.model.access.csv | 3 +++ estate/views/estate_menus.xml | 7 ++++- estate/views/estate_property_views.xml | 36 ++++++++++++++++++-------- 6 files changed, 58 insertions(+), 21 deletions(-) diff --git a/estate/__manifest__.py b/estate/__manifest__.py index 05e007850c5..f7bf7e3b838 100644 --- a/estate/__manifest__.py +++ b/estate/__manifest__.py @@ -1,6 +1,6 @@ # __manifest__.py { # noqa: B018 - "author": "mawat", + "author": "Odoo S.A.", "name": "estate", "depends": ["base"], "application": True, @@ -8,6 +8,9 @@ "data": [ "security/ir.model.access.csv", "views/estate_property_views.xml", + "views/estate_property_type_views.xml", + "views/estate_property_tag_views.xml", + "views/estate_property_offer_views.xml", "views/estate_menus.xml" ], } diff --git a/estate/models/__init__.py b/estate/models/__init__.py index 5e1963c9d2f..2f1821a39c1 100644 --- a/estate/models/__init__.py +++ b/estate/models/__init__.py @@ -1 +1,4 @@ from . import estate_property +from . import estate_property_type +from . import estate_property_tag +from . import estate_property_offer diff --git a/estate/models/estate_property.py b/estate/models/estate_property.py index 30aebcd1877..eeae16f93a9 100644 --- a/estate/models/estate_property.py +++ b/estate/models/estate_property.py @@ -1,5 +1,4 @@ -from odoo.tools import date_utils - +from odoo.tools.date_utils import add from odoo import fields, models @@ -19,16 +18,26 @@ class EstateProperty(models.Model): name = fields.Char(required=True) description = fields.Text() postcode = fields.Char() - date_availability = fields.Date(copy=False, default=lambda self: date_utils.add(fields.Date.today(), months=3)) + date_availability = fields.Date(copy=False, default=lambda self: add(fields.Date.today(), months=3), string="Available From") expected_price = fields.Float(required=True) selling_price = fields.Float(readonly=True, copy=False) bedrooms = fields.Integer(default=2) - living_area = fields.Integer() + living_area = fields.Integer(string="Living Area (sqm)") facades = fields.Integer() - garage = fields.Boolean() - garden = fields.Boolean() - garden_area = fields.Integer() + has_garage = fields.Boolean() + has_garden = fields.Boolean() + garden_area = fields.Integer(string="Garden Area (sqm)") garden_orientation = fields.Selection( string='Type', - selection=[('North', 'North'), ('South', 'South'), ('East', 'East'), ('West', 'West')] + selection=[ + ('north', 'North'), + ('south', 'South'), + ('east', 'East'), + ('west', 'West') + ] ) + property_type_id = fields.Many2one("estate.property.type", string="Property Type") + buyer = fields.Many2one('res.partner', copy=False) + salesperson = fields.Many2one('res.users', default=lambda self: self.env.user, string="Salesman") + tag_ids = fields.Many2many('estate.property.tag') + offer_ids = fields.One2many('estate.property.offer', 'property_id', string="Offers") diff --git a/estate/security/ir.model.access.csv b/estate/security/ir.model.access.csv index ed7060e60a7..50c78b6d5f5 100644 --- a/estate/security/ir.model.access.csv +++ b/estate/security/ir.model.access.csv @@ -1,2 +1,5 @@ id,name,model_id/id,group_id/id,perm_read,perm_write,perm_create,perm_unlink access_estate_property,estate_property,model_estate_property,base.group_user,1,1,1,1 +access_estate_property_type,estate_property_type,model_estate_property_type,base.group_user,1,1,1,1 +access_estate_property_tag,estate_property_tag,model_estate_property_tag,base.group_user,1,1,1,1 +access_estate_property_offer,estate_property_offer,model_estate_property_offer,base.group_user,1,1,1,1 diff --git a/estate/views/estate_menus.xml b/estate/views/estate_menus.xml index f12c6192cf8..c1090a0997a 100644 --- a/estate/views/estate_menus.xml +++ b/estate/views/estate_menus.xml @@ -1,8 +1,13 @@ - + + + + + + diff --git a/estate/views/estate_property_views.xml b/estate/views/estate_property_views.xml index cfe148e2626..c428697e329 100644 --- a/estate/views/estate_property_views.xml +++ b/estate/views/estate_property_views.xml @@ -6,15 +6,14 @@ + - + - + @@ -33,8 +32,12 @@ + + + + - + @@ -46,14 +49,23 @@ - + - - - + + + + + + + + + + + + @@ -66,12 +78,14 @@ + - + - + + From 94e79598e926517e7642b073342783c18343e552 Mon Sep 17 00:00:00 2001 From: mawat-odoo Date: Thu, 17 Sep 2026 14:55:16 +0200 Subject: [PATCH 10/10] [IMP] estate: add SQL and Python constraints Enforce data integrity rules on properties, offers, tags, and types to prevent invalid user input: - Add SQL constraints to ensure expected_price and offer price are strictly positive (> 0), selling_price is positive (>= 0), and property tag/type names are unique. - Add Python constraint _check_selling_price using float_compare and float_is_zero to prevent selling price from dropping below 90% of expected price once set. task-6573564 --- estate/models/estate_property.py | 61 +++++++++++++++++++- estate/models/estate_property_offer.py | 43 +++++++++++++- estate/models/estate_property_tag.py | 6 ++ estate/models/estate_property_type.py | 1 + estate/views/estate_property_offer_views.xml | 10 ++++ estate/views/estate_property_views.xml | 10 +++- 6 files changed, 127 insertions(+), 4 deletions(-) diff --git a/estate/models/estate_property.py b/estate/models/estate_property.py index eeae16f93a9..f7bacff52d8 100644 --- a/estate/models/estate_property.py +++ b/estate/models/estate_property.py @@ -1,5 +1,7 @@ from odoo.tools.date_utils import add -from odoo import fields, models +from odoo.tools.float_utils import float_compare, float_is_zero +from odoo.exceptions import UserError, ValidationError +from odoo import api, fields, models class EstateProperty(models.Model): @@ -41,3 +43,60 @@ class EstateProperty(models.Model): salesperson = fields.Many2one('res.users', default=lambda self: self.env.user, string="Salesman") tag_ids = fields.Many2many('estate.property.tag') offer_ids = fields.One2many('estate.property.offer', 'property_id', string="Offers") + total_area = fields.Integer(compute="_compute_total_area", string="Total Area (sqm)") + best_price = fields.Float(compute="_compute_best_offer", string="Best Offer") + + @api.depends("living_area", "garden_area") + def _compute_total_area(self): + for record in self: + record.total_area = record.living_area + record.garden_area + + @api.depends("offer_ids.price") + def _compute_best_offer(self): + for record in self: + prices = record.offer_ids.mapped("price") + record.best_price = max(prices) if prices else 0.0 + + @api.onchange("has_garden") + def _onchange_has_garden(self): + if self.has_garden: + self.garden_area = 10 + self.garden_orientation = "north" + else: + self.garden_area = 0 + self.garden_orientation = None + + def mark_order_as_sold(self): + for record in self: + if record.state == "cancelled": + raise UserError("Cancelled properties cannot be sold") + else: + record.state = "sold" + return True + + def mark_order_as_cancelled(self): + for record in self: + if record.state == "sold": + raise UserError("Sold properties cannot be cancelled") + else: + record.state = "cancelled" + return True + + @api.constrains("selling_price", "expected_price") + def _check_selling_price(self): + for record in self: + if float_is_zero(record.selling_price, precision_digits=2): + continue + + if float_compare(record.selling_price, 0.9 * record.expected_price, precision_digits=2) < 0: + raise ValidationError("The selling price must be at leat 90% of the expected price ! You must reduce the expected price if you want to accept this order !") + + _expected_price_strictly_positive_constraint = models.Constraint( + "CHECK(expected_price > 0)", + "The expected price should be strictly greater than 0!" + ) + + _selling_price_positive_constraint = models.Constraint( + "CHECK(selling_price >= 0)", + "The selling price should be greater or equal to 0!" + ) diff --git a/estate/models/estate_property_offer.py b/estate/models/estate_property_offer.py index 6f553cb87e2..910fe7955d7 100644 --- a/estate/models/estate_property_offer.py +++ b/estate/models/estate_property_offer.py @@ -1,4 +1,6 @@ -from odoo import fields, models +from odoo.tools.date_utils import add +from odoo.exceptions import UserError +from odoo import api, fields, models class EstatePropertyOffer(models.Model): @@ -12,3 +14,42 @@ class EstatePropertyOffer(models.Model): ], copy=False) partner_id = fields.Many2one("res.partner", required=True, string="Partner") property_id = fields.Many2one("estate.property", required=True) + validity = fields.Integer(default=7, string="Validity (days)") + date_deadline = fields.Date(compute="_compute_date_deadline", inverse="_inverse_date_deadline", string="Deadline") + + @api.depends("create_date", "validity") + def _compute_date_deadline(self): + for record in self: + base_date = record.create_date.date() if record.create_date else fields.Date.today() + record.date_deadline = add(base_date, days=record.validity) + + def _inverse_date_deadline(self): + for record in self: + base_date = record.create_date.date() if record.create_date else fields.Date.today() + if record.date_deadline and base_date: + record.validity = (record.date_deadline - base_date).days + + def accept_offer(self): + for record in self: + + if record.status == "accepted": + continue + + accepted_offer = record.property_id.offer_ids.filtered(lambda offer: offer.status == "accepted") + if accepted_offer: + raise UserError("Only one offer can be accepted for a giver property !") + else: + record.status = "accepted" + record.property_id.buyer = record.partner_id + record.property_id.selling_price = record.price + return True + + def refuse_offer(self): + for record in self: + record.status = "refused" + return True + + _offer_price_strictly_positive_constraint = models.Constraint( + "CHECK(price > 0)", + "The price of an offer should be strictly greater than 0!" + ) diff --git a/estate/models/estate_property_tag.py b/estate/models/estate_property_tag.py index 47210e31c43..bb1d38399dd 100644 --- a/estate/models/estate_property_tag.py +++ b/estate/models/estate_property_tag.py @@ -1,7 +1,13 @@ from odoo import fields, models + class EstatePropertyTag(models.Model): _name = "estate.property.tag" _description = "Estate property tag model" name = fields.Char(required=True) + + _property_tag_unique_constraint = models.Constraint( + "UNIQUE(name)", + "Property tag should have an unique name!" + ) diff --git a/estate/models/estate_property_type.py b/estate/models/estate_property_type.py index 8a49e97c224..245d526f62e 100644 --- a/estate/models/estate_property_type.py +++ b/estate/models/estate_property_type.py @@ -1,5 +1,6 @@ from odoo import fields, models + class EstatePropertyType(models.Model): _name = "estate.property.type" _description = "Estate property type model" diff --git a/estate/views/estate_property_offer_views.xml b/estate/views/estate_property_offer_views.xml index 276aa7570b7..c548eeba601 100644 --- a/estate/views/estate_property_offer_views.xml +++ b/estate/views/estate_property_offer_views.xml @@ -5,6 +5,10 @@ estate.property.offer
+
+

@@ -12,6 +16,8 @@ + + @@ -26,6 +32,10 @@ + + +