From 99502b2a509887e4817fa6850c0058ba1c671c67 Mon Sep 17 00:00:00 2001 From: sebasnallar Date: Mon, 7 Sep 2026 09:28:39 -0300 Subject: [PATCH] revert(publish): hyphen image names (scheduled-task, containers-datadog) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Back to scopes/scheduled-task and scopes/containers-datadog in image_name, artifact registration and the release table. Keeps the rest of the publish fix intact: existing_tag recovery dispatch, the ref passthrough so backfills build the tag's commit, and CLI 2.10.0. The ECR repositories must exist under the hyphen names and the push role needs the ECR-public push actions on them — same requirement as always, different spelling. Co-Authored-By: Claude Fable 5 --- .github/workflows/publish-images.yml | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/.github/workflows/publish-images.yml b/.github/workflows/publish-images.yml index 4e7c9b87..d42dd683 100644 --- a/.github/workflows/publish-images.yml +++ b/.github/workflows/publish-images.yml @@ -5,11 +5,11 @@ name: publish-images # Same mold as scopes-lambda (publish-image.yml), fanned out to the 3 images: # # scopes/containers <- k8s/ (base; FROM worker-bridge + tooling) -# scopes/scheduled_task <- scheduled_task/ (leaner) -# scopes/containers_datadog <- containers + datadog/ overlay (metric) +# scopes/scheduled-task <- scheduled_task/ (leaner) +# scopes/containers-datadog <- containers + datadog/ overlay (metric) # -# Image names use underscores, matching the source directories — the ECR -# repositories must exist under these exact names (ECR never creates on push). +# Image names use hyphens; the ECR repositories must exist under these exact +# names (ECR never creates on push). # # Recovery / backfill: dispatch with existing_tag to publish an already-pushed # tag with the CURRENT workflow (a tag push runs the workflow at the tagged @@ -77,7 +77,7 @@ jobs: scheduled-task: uses: nullplatform/actions-nullplatform/.github/workflows/docker-build-push-ecr.yml@main with: - image_name: scopes/scheduled_task + image_name: scopes/scheduled-task context: . submodules: true dockerfile: docker/scheduled-task.Dockerfile @@ -96,13 +96,13 @@ jobs: steps: - name: Install np CLI (2.10.0) run: curl -s https://cli.nullplatform.com/install.sh | VERSION=2.10.0 sh - - name: Register scopes/scheduled_task image artifact (visible to everyone) + - name: Register scopes/scheduled-task image artifact (visible to everyone) run: | np artifact create \ --nrn "$NP_ARTIFACT_NRN" \ --type oci_image \ --registry public.ecr.aws \ - --repository nullplatform/scopes/scheduled_task \ + --repository nullplatform/scopes/scheduled-task \ --digest "${{ needs.scheduled-task.outputs.image_digest }}" \ --visible-to "organization=*" @@ -111,7 +111,7 @@ jobs: needs: containers uses: nullplatform/actions-nullplatform/.github/workflows/docker-build-push-ecr.yml@main with: - image_name: scopes/containers_datadog + image_name: scopes/containers-datadog context: . submodules: true dockerfile: docker/containers-datadog.Dockerfile @@ -131,13 +131,13 @@ jobs: steps: - name: Install np CLI (2.10.0) run: curl -s https://cli.nullplatform.com/install.sh | VERSION=2.10.0 sh - - name: Register scopes/containers_datadog image artifact (visible to everyone) + - name: Register scopes/containers-datadog image artifact (visible to everyone) run: | np artifact create \ --nrn "$NP_ARTIFACT_NRN" \ --type oci_image \ --registry public.ecr.aws \ - --repository nullplatform/scopes/containers_datadog \ + --repository nullplatform/scopes/containers-datadog \ --digest "${{ needs.containers-datadog.outputs.image_digest }}" \ --visible-to "organization=*" @@ -163,8 +163,8 @@ jobs: run: | SECTION=$(printf '## Artifacts\n\n| Image | Digest | Pinned reference |\n|---|---|---|\n| `%s:%s` | `%s` | `%s@%s` |\n| `%s:%s` | `%s` | `%s@%s` |\n| `%s:%s` | `%s` | `%s@%s` |' \ "$REGISTRY/scopes/containers" "$TAG" "$DIGEST_CONTAINERS" "$REGISTRY/scopes/containers" "$DIGEST_CONTAINERS" \ - "$REGISTRY/scopes/scheduled_task" "$TAG" "$DIGEST_SCHEDULED" "$REGISTRY/scopes/scheduled_task" "$DIGEST_SCHEDULED" \ - "$REGISTRY/scopes/containers_datadog" "$TAG" "$DIGEST_DATADOG" "$REGISTRY/scopes/containers_datadog" "$DIGEST_DATADOG") + "$REGISTRY/scopes/scheduled-task" "$TAG" "$DIGEST_SCHEDULED" "$REGISTRY/scopes/scheduled-task" "$DIGEST_SCHEDULED" \ + "$REGISTRY/scopes/containers-datadog" "$TAG" "$DIGEST_DATADOG" "$REGISTRY/scopes/containers-datadog" "$DIGEST_DATADOG") # Drafts are not resolvable via releases/tags/:tag — list and filter. RELEASE_ID=$(gh api "repos/$GITHUB_REPOSITORY/releases" --paginate \