From 5d6d8e9c60850887a4aefd713c6d4a7b0c4f987f Mon Sep 17 00:00:00 2001 From: Dan Mosedale Date: Sun, 16 Aug 2026 19:06:20 -0400 Subject: [PATCH] Route Firefox :: Messaging System bugs to #omc-triage Add the desktop Messaging System (about:welcome, feature callouts, Spotlight, Infobars) as a triaged area: a SLACK_CHANNELS entry for "Firefox :: Messaging System", the matching README routing row and component list entry, and the source locations (browser/components/asrouter/, browser/components/aboutwelcome/, toolkit/components/messaging-system/) in the triage rules so localization has somewhere to look. --- agents/frontend-triage/README.md | 2 ++ .../hackbot_agents/frontend_triage/config.py | 1 + .../frontend_triage/rules/frontend-triage.md | 14 +++++++++----- agents/frontend-triage/tests/test_notify.py | 1 + 4 files changed, 13 insertions(+), 5 deletions(-) diff --git a/agents/frontend-triage/README.md b/agents/frontend-triage/README.md index f7077d13f4..e8dfccfa7c 100644 --- a/agents/frontend-triage/README.md +++ b/agents/frontend-triage/README.md @@ -22,6 +22,7 @@ to reproduce, or a log rather than a stack trace: - **Firefox for Android**: History. Kotlin under `mobile/android/fenix/`. - **Install and update**: `Firefox :: Installer` (NSIS) and `Toolkit :: Application Update` (`.sys.mjs`, IDL, C++). +- **Messaging System**: `Firefox :: Messaging System` (incl. about:welcome, feature callouts, Spotlight modal dialogs, Infobars). Install and update bugs are the odd ones out: they arrive as a failure with an error code and an `update.log` or installer log, usually with no steps to @@ -181,6 +182,7 @@ Routing is `SLACK_CHANNELS` in `config.py`, keyed by `" :: " | `Firefox for Android :: History` | `#android-core-dev` | | `Toolkit :: Application Update` | `#installer-updater-bug-triage` | | `Firefox :: Installer` | `#installer-updater-bug-triage` | +| `Firefox :: Messaging System` | `#omc-triage` | Two components may share a channel, as the installer and the updater do; the key is the component, not the team. A component that is not listed notifies nobody; there is diff --git a/agents/frontend-triage/hackbot_agents/frontend_triage/config.py b/agents/frontend-triage/hackbot_agents/frontend_triage/config.py index ac6987e0df..8ba2af6a3f 100644 --- a/agents/frontend-triage/hackbot_agents/frontend_triage/config.py +++ b/agents/frontend-triage/hackbot_agents/frontend_triage/config.py @@ -58,6 +58,7 @@ # lets them, without either one having to know about the other. "Toolkit :: Application Update": "#installer-updater-bug-triage", "Firefox :: Installer": "#installer-updater-bug-triage", + "Firefox :: Messaging System": "#omc-triage", } # What a `bugzilla.update_bug` from this agent may touch. Enforced at record time diff --git a/agents/frontend-triage/hackbot_agents/frontend_triage/rules/frontend-triage.md b/agents/frontend-triage/hackbot_agents/frontend_triage/rules/frontend-triage.md index 585ed395e2..8b11e56601 100644 --- a/agents/frontend-triage/hackbot_agents/frontend_triage/rules/frontend-triage.md +++ b/agents/frontend-triage/hackbot_agents/frontend_triage/rules/frontend-triage.md @@ -1,14 +1,15 @@ # User-facing Firefox defect triage These rules apply to **defects in user-facing Firefox** — the desktop frontend, -Firefox for Android, and the Windows installer and application updater. Typical -components: +Firefox for Android, the Windows installer and application updater, and the +(desktop) Messaging System. Typical components: - Desktop frontend, all under `Firefox`: `Tabbed Browser`, `Tabbed Browser: Split View`, `New Tab Page`, `Address Bar`, `Menus`, `Toolbars and Customization`, `Sidebar`, `Theme`. - Android: `Firefox for Android :: History`. - Install and update: `Firefox :: Installer`, `Toolkit :: Application Update`. +- Messaging System: `Firefox :: Messaging System`. Desktop and Android bugs here are usually UI/UX papercuts, documented with a **video or screenshot** and steps to reproduce. @@ -37,9 +38,12 @@ Core, DevTools-internals, or build-system bug — and say which area it looks li `devtools/` (JS/JSM, CSS, XUL/HTML); Android under `mobile/android/` (Kotlin, Fragment/Store/Middleware/View); the updater under `toolkit/mozapps/update/` (`.sys.mjs`, IDL, C++); the installer under `browser/installer/windows/nsis/` - (NSIS `.nsi`/`.nsh`). Find the module, the markup or layout, and any relevant pref - (often `modules/libpref/init/all.js`, or `app.update.*` for the updater) that - governs the behaviour. Use the `investigator` subagent for deep searches. + (NSIS `.nsi`/`.nsh`), Messaging System under `browser/components/asrouter/`, + `browser/components/aboutwelcome/`, `toolkit/components/messaging-system/` + (JS/JSM, CSS, XUL/HTML, JSON, JSON Schema). Find the module, the markup or layout, + and any relevant pref (often `modules/libpref/init/all.js`, or `app.update.*` + for the updater) that governs the behaviour. Use the `investigator` subagent for + deep searches. 2. **Confirm the area is still live.** Check the referenced code/strings still exist and aren't already changed by a recent commit. If the bug looks already fixed (e.g. cannot reproduce on a newer version per comments, or the code path diff --git a/agents/frontend-triage/tests/test_notify.py b/agents/frontend-triage/tests/test_notify.py index 429ee82451..fa5ee96965 100644 --- a/agents/frontend-triage/tests/test_notify.py +++ b/agents/frontend-triage/tests/test_notify.py @@ -91,6 +91,7 @@ def test_the_channel_belongs_to_the_component(): assert channel_for("Firefox for Android", "History") == "#android-core-dev" # Surrounding whitespace is the agent's, not Bugzilla's. assert channel_for(" Firefox ", " New Tab Page ") == "#hnt-dev-triage" + assert channel_for("Firefox", "Messaging System") == "#omc-triage" def test_the_installer_and_the_updater_share_a_channel():