From f27f4c51c283b65c6c11b79108fc3e6d1ae0dc41 Mon Sep 17 00:00:00 2001 From: edgchen1 <18449977+edgchen1@users.noreply.github.com> Date: Tue, 15 Sep 2026 15:21:28 -0700 Subject: [PATCH 1/2] Add review guidance for deprecated components Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --- .../acl-deprecated.instructions.md | 15 +++++++++++++ .../jsep-deprecated.instructions.md | 21 +++++++++++++++++++ .../webgl-deprecated.instructions.md | 19 +++++++++++++++++ 3 files changed, 55 insertions(+) create mode 100644 .github/instructions/acl-deprecated.instructions.md create mode 100644 .github/instructions/jsep-deprecated.instructions.md create mode 100644 .github/instructions/webgl-deprecated.instructions.md diff --git a/.github/instructions/acl-deprecated.instructions.md b/.github/instructions/acl-deprecated.instructions.md new file mode 100644 index 0000000000000..b2f0e6a26b5fd --- /dev/null +++ b/.github/instructions/acl-deprecated.instructions.md @@ -0,0 +1,15 @@ +--- +description: "Review guidance for changes to the deprecated ACL execution provider and its eventual removal." +applyTo: "onnxruntime/core/providers/acl/**,include/onnxruntime/core/providers/acl/**,cmake/onnxruntime_providers_acl.cmake" +--- + +# Deprecated ACL Execution Provider + +The ACL EP is deprecated and will be removed in a future release. + +## Review Policy + +Report changes that expand or prolong the deprecated ACL EP surface and require explicit maintainer justification +that the scope is appropriate. + +Accept changes that directly remove code or enable removal. diff --git a/.github/instructions/jsep-deprecated.instructions.md b/.github/instructions/jsep-deprecated.instructions.md new file mode 100644 index 0000000000000..054d46e7cf60b --- /dev/null +++ b/.github/instructions/jsep-deprecated.instructions.md @@ -0,0 +1,21 @@ +--- +description: "Review guidance for changes to the deprecated JSEP implementation and its removal or migration." +applyTo: "onnxruntime/core/providers/js/**,onnxruntime/contrib_ops/js/**,js/web/lib/wasm/jsep/**,onnxruntime/wasm/pre-jsep.js,cmake/onnxruntime_providers_js.cmake,js/build_jsep.bat" +--- + +# Deprecated JSEP + +JSEP is deprecated and is being replaced by the native WebGPU EP. Follow the contribution policy in +[`docs/JSEP_Deprecation.md`](../../docs/JSEP_Deprecation.md), which is the authoritative source for its status and +accepted changes. + +## Review Policy + +Report new operators, features, or performance-only work as actionable findings and direct that work to the native +WebGPU EP in `onnxruntime/core/providers/webgpu/` or `onnxruntime/contrib_ops/webgpu/`. + +Accept correctness and security fixes to existing behavior. Require focused regression coverage for an accepted JSEP +fix. + +Accept deprecation, migration, or removal work. Read and follow +[`docs/design/onnxruntime_web_jsep_to_webgpu_ep_migration.md`](../../docs/design/onnxruntime_web_jsep_to_webgpu_ep_migration.md). diff --git a/.github/instructions/webgl-deprecated.instructions.md b/.github/instructions/webgl-deprecated.instructions.md new file mode 100644 index 0000000000000..8e228d78417b2 --- /dev/null +++ b/.github/instructions/webgl-deprecated.instructions.md @@ -0,0 +1,19 @@ +--- +description: "Review guidance for maintenance and removal of the deprecated onnxruntime-web WebGL backend." +applyTo: "js/web/lib/onnxjs/backends/webgl/**,js/web/lib/onnxjs/backends/backend-webgl.ts,js/web/lib/backend-onnxjs.ts,js/web/test/unittests/backends/webgl/**,js/web/test/e2e/browser-test-webgl.js,js/web/script/generate-webgl-operator-md.ts,js/web/docs/webgl-operators.md" +--- + +# Deprecated WebGL Backend + +The onnxruntime-web WebGL backend is deprecated and scheduled for removal. + +## Review Policy + +Report changes that expand the WebGL backend with new operators, features, or performance work. Direct new GPU work +to WebGPU and users who cannot use WebGPU to the WASM/CPU backend. + +Accept correctness and security fixes to existing behavior. Require focused regression coverage for an accepted WebGL +backend fix. + +Accept deprecation and removal work. Read and follow +[`docs/design/onnxruntime_web_remove_webgl_backend.md`](../../docs/design/onnxruntime_web_remove_webgl_backend.md). From 8ff5e690d513d866ce7768a53e5c0ccca866a24d Mon Sep 17 00:00:00 2001 From: edgchen1 <18449977+edgchen1@users.noreply.github.com> Date: Tue, 15 Sep 2026 17:08:35 -0700 Subject: [PATCH 2/2] Require native WebGPU checks for JSEP fixes Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --- .github/instructions/jsep-deprecated.instructions.md | 3 +++ docs/JSEP_Deprecation.md | 3 +++ 2 files changed, 6 insertions(+) diff --git a/.github/instructions/jsep-deprecated.instructions.md b/.github/instructions/jsep-deprecated.instructions.md index 054d46e7cf60b..ecb3deb911eb2 100644 --- a/.github/instructions/jsep-deprecated.instructions.md +++ b/.github/instructions/jsep-deprecated.instructions.md @@ -17,5 +17,8 @@ WebGPU EP in `onnxruntime/core/providers/webgpu/` or `onnxruntime/contrib_ops/we Accept correctness and security fixes to existing behavior. Require focused regression coverage for an accepted JSEP fix. +For a JSEP WebGPU kernel fix, inspect the corresponding native WebGPU EP implementation. Report an actionable finding +if the same defect applies there but the change does not include the native fix and focused regression coverage. + Accept deprecation, migration, or removal work. Read and follow [`docs/design/onnxruntime_web_jsep_to_webgpu_ep_migration.md`](../../docs/design/onnxruntime_web_jsep_to_webgpu_ep_migration.md). diff --git a/docs/JSEP_Deprecation.md b/docs/JSEP_Deprecation.md index cc74749e3b8bc..4721fb156a5c4 100644 --- a/docs/JSEP_Deprecation.md +++ b/docs/JSEP_Deprecation.md @@ -17,6 +17,9 @@ JSEP is in maintenance mode: **bug fixes and security fixes only.** | New operator | The native WebGPU EP — `onnxruntime/core/providers/webgpu/` or `onnxruntime/contrib_ops/webgpu/` | | New feature, or performance work | The native WebGPU EP | +For a correctness or security fix to a JSEP WebGPU kernel, check the corresponding native WebGPU EP implementation +and include the equivalent fix and regression coverage when the same defect applies. + Note that [`js/web/docs/webgpu-operators.md`](../js/web/docs/webgpu-operators.md) lists **JSEP** operators despite its name, so it cannot be used to check what the native WebGPU EP already covers.