From 76ad8ac437321e6b7e4d3de40cd559c0920b5a8a Mon Sep 17 00:00:00 2001 From: Kim Kulling Date: Sat, 5 Sep 2026 20:00:27 +0200 Subject: [PATCH 1/3] Fix review findings. --- src/tinyui.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/tinyui.cpp b/src/tinyui.cpp index b782264..afd992a 100644 --- a/src/tinyui.cpp +++ b/src/tinyui.cpp @@ -85,7 +85,9 @@ Context *Context::create(const char *title, const Style &style, tui_log_func log ctx->mWindowsTitle = title; ctx->mStyle = style; - logVersion(*ctx); + if (ctx->mLogger != nullptr) { + logVersion(*ctx); + } return ctx; } From 360dfbfb4c3eae1988ddde3fa222739242bce54c Mon Sep 17 00:00:00 2001 From: Kim Kulling Date: Sat, 5 Sep 2026 21:26:32 +0200 Subject: [PATCH 2/3] Update GTest package find command to CONFIG mode --- test/CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/CMakeLists.txt b/test/CMakeLists.txt index 85f2414..7dacced 100644 --- a/test/CMakeLists.txt +++ b/test/CMakeLists.txt @@ -1,7 +1,7 @@ cmake_minimum_required(VERSION 3.10) # Find GoogleTest package (should be found in main CMakeLists.txt) -find_package(GTest REQUIRED) +find_package(GTest CONFIG REQUIRED) # Enable testing enable_testing() From 1b7ce5ffc466b7a8fbc98943692e0b6ff8c57e46 Mon Sep 17 00:00:00 2001 From: Kim Kulling Date: Sat, 5 Sep 2026 21:31:29 +0200 Subject: [PATCH 3/3] Update CMake workflow to include testing libraries Added libgtest and googletest to the dependencies installation. --- .github/workflows/cmake.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/cmake.yml b/.github/workflows/cmake.yml index f74135f..ac66325 100644 --- a/.github/workflows/cmake.yml +++ b/.github/workflows/cmake.yml @@ -26,7 +26,7 @@ jobs: run: | sudo add-apt-repository -y "deb http://archive.ubuntu.com/ubuntu `lsb_release -sc` main universe restricted multiverse" sudo apt-get update -y -qq - sudo apt-get install libsdl2-dev libsdl2-image-dev libsdl2-ttf-dev + sudo apt-get install libsdl2-dev libsdl2-image-dev libsdl2-ttf-dev libgtest-dev googletest - name: Configure CMake # Configure CMake in a 'build' subdirectory. `CMAKE_BUILD_TYPE` is only required if you are using a single-configuration generator such as make.