Regex validation error

[krystek-dev]

I have created example project where you can find not working regex as expected.

I would like to have modules that ends with "Ui" in their name. So there should be allowed to reference/depend from non UI modules to UI but UI module cannot depends another UI module.

For example modules:

• composeApp
• libUi
• testUi
• another

The composeApp could depends another and all Uis, but libUi can depends composeApp (logically do not need that) but could also depends another.
So i found restrictions that module that ends with Ui could refers just non-ending Ui modules and modules that not ends with Ui could reference all modules.

Non ending modules regex: ^(?!.*Ui$).*$
All modules regex: .*

Ending Ui regex: .*Ui$
Modules that NOT ends with Ui: ^(?!.*Ui$).*$

Regex could be checked https://regex101.com/

There is configuration

moduleGraphAssert {
    configurations += setOf("commonMainImplementation", "commonMainApi")
    maxHeight = 3
    allowed = arrayOf(
        ".*Ui$ -> ^(?!.*Ui$).*$",
        "^(?!.*Ui$).*$  -> .*",
    )
    restricted = arrayOf(
    )
    assertOnAnyBuild = true
}

Build build ends with error:
Failed to notify build listener.

[':composeApp' -> ':shared'] not allowed by any of ['.Ui$ -> ^(?!.Ui$).$', '^(?!.Ui$).$ -> .']
[':shared:libUi' -> ':shared:testUi'] not allowed by any of [':.Ui$ -> ^(?!.Ui$).$', '^(?!.Ui$).$ -> .']

The sample project:
MyApplication.zip

[jraska]

Hey, thanks for raising the issues(s). To help eventually make this fixed could you provide a failing test?

Perhaps similar to: https://github.com/jraska/modules-graph-assert/blob/master/plugin/src/test/kotlin/com/jraska/module/graph/ParseTest.kt#L34

I could figure this out obviously, but I would take more time so having a reproducible test to fix would help.

[jraska]

Checked

When I used ^(?!.*Ui$).* -> .* instead of (?!.*Ui$).*$ -> .* the matchers work. https://regex101.com/r/rLt6Zo/1

Isn't the issue the used regex?

[krystek-dev]

OK i found two issues right now

Firstly i wrote "^(?!.*Ui$).*$ -> .*", where are two spaces before -> which causes not validate regex correctly.

Secondary you wrote example in regex101 ^(?!.*Ui$).* -> .* that contains -> (space arrow space) which means there is not validating regex individually for each package in the plugin so there could not be $ as i wrote before.

So i recommend to split allow/restrict string by -> (arrow), then remove whitespaces from start and end of string and correctly response regex
That means split ^(?!.*Ui$).*$ -> .* to ["^(?!.*Ui$).*$ ", " .*"], then remove extra whitespaces (optional) ["^(?!.*Ui$).*$", ".*"] and apply regex.

Do you agree ?

[jraska]

split allow/restrict string by ->

❌ This will fail: ParseTest.kt#L34 and would revert: #54. The arrow requirement in the regex is intentional.

Again I would suggest update the regexes and I believe you can achieve what you need.

Otherwise I recommend PR and/or show a failing test like this so I can clearly understand and any change can be verified. https://github.com/jraska/modules-graph-assert/blob/master/plugin/src/test/kotlin/com/jraska/module/graph/assertion/OnlyAllowedAssertTest.kt#L37

[krystek-dev]

The main issue is from bad documentation of regex i guess.

There is in readme file:

Define the only allowed dependencies between modules
allowed = [':feature-one -> :feature-[a-z-:]*', ':.* -> :core', ':feature.* -> :lib.*'] define rules by using regex -> regex signature.
Dependency, which will not match any of those rules will fail the assertion.
restricted [':feature-[a-z]* -X> :forbidden-to-depend-on'] helps us to define custom rules by using regex -X> regex signature.

regex -> regex which means there should be two regular strings but you described and mentioned #54 there is regex as a whole string so there cannot be $ that means end of string in front of -> chars

So if you want to keep #54 i recommend to add this information to readme file :)