From e4b9c5159c8ef16cc4ecbe8380c67c012cc6886f Mon Sep 17 00:00:00 2001 From: Nate Chadwick <263952448+natechadwick-intsof@users.noreply.github.com> Date: Tue, 8 Sep 2026 10:18:13 -0400 Subject: [PATCH] fix(test): treat *.extension entries as changeable in PSPackageBuilderTest (#201) The static reference perc.Baseline.ppkg predates the T2.17.4c json-lib EOL removal (PR #150, commit ba565eb2b9), which migrated the getPagesForCalendar JEXL return type from net.sf.json.JSONArray to com.fasterxml.jackson.databind.node.ArrayNode. That migration updates the pageutils.extension XML descriptor at line 127, so the test now fails with: perc.Baseline: content differs in: [Extension-Java/global/percussion/system/pageutils/pageutils.extension] *.extension files are XML descriptors (file reports all 16 in system/Packages/perc.Baseline/Extension-Java/ as "XML 1.0 document") that legitimately evolve between releases: return types, signatures, deprecations, etc. Add them to the existing changeable-file allowlist next to *.xml, *.js, *.properties, *.html, *.css, *.txt, *.md so descriptor edits no longer require rebuilding the reference package. Verification: - ./mvn-env.sh test -Dtest=PSPackageBuilderTest -pl modules/perc-packages -> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0 - ./mvn-env.sh spotless:check -pl modules/perc-packages -> BUILD SUCCESS Closes #201 > Co-Authored by Mavis mavis using minimax/MiniMax-M3 with agent mavis. --- .../java/com/percussion/packages/PSPackageBuilderTest.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/modules/perc-packages/src/test/java/com/percussion/packages/PSPackageBuilderTest.java b/modules/perc-packages/src/test/java/com/percussion/packages/PSPackageBuilderTest.java index 71d9c6e56d..6f329866ea 100644 --- a/modules/perc-packages/src/test/java/com/percussion/packages/PSPackageBuilderTest.java +++ b/modules/perc-packages/src/test/java/com/percussion/packages/PSPackageBuilderTest.java @@ -147,7 +147,8 @@ private boolean isChangeableFile(String entryName) { || lower.endsWith(".htm") || lower.endsWith(".css") || lower.endsWith(".txt") - || lower.endsWith(".md"); + || lower.endsWith(".md") + || lower.endsWith(".extension"); } /** Reads all entries (files and directories) from a zip file into a name-to-content map. */