Add Properties to image

[JoeyG1973]

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request.
If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Description

Please allow the ability to add properties to the image

Use Case(s)

openstack image set --property key=value needs to be run after the image is created using an external process.

Setting properties in OpenStack for the image should be part of packer proper

Potential configuration

"properties": {
	                 "os_distro": "ubuntu"
                         "os_version": "22.04"
	             }

Potential References

[nywilken]

Hi @JoeyG1973 thanks for reaching out here. This is a community maintained plugin so the Packer team won't work on this change. But we are happy to review a pull-request if you are or a member of the community is interested in making the change.

That said, are these properties different from the properties that can be set via the the external_source_image_properties?

[JoeyG1973]

Hi @JoeyG1973 thanks for reaching out here. This is a community maintained plugin so the Packer team won't work on this change. But we are happy to review a pull-request if you are or a member of the community is interested in making the change.

That said, are these properties different from the properties that can be set via the the external_source_image_properties?

Hi @nywilken,

The description on external_source_image_properties clarifies nothing so I am not really sure what it is supposed to do. :)

[JoeyG1973]

I am still trying to figure out what https://www.packer.io/plugins/builders/openstack#external_source_image_properties is supposed to be. Is it a filter on properties for what external image to choose or does it set properties on the packer output image?

[cortexx]

Hello,

I asked myself the same question a few days ago and found your issue.

So here my 2 cents:

• As defined here, the external_source_image_properties is used as options given during image creation
• After some tests, I confirm that added properties are properly set to the generated image
• I found the documentation a bit confusing on this subject

Hoping that my comment will be useful.

[vydrazde]

Looking at the source code, external_source_image_properties and external_source_image_format are used when creating a temporary image from external_source_image_url. Since OpenStack cannot launch an image from an external URL directly, the image is downloaded from the URL, imported to OpenStack with these options and deleted after the resulting image is finished.

These properties may be inherited by the resulting image as @cortexx reported, but when external_source_image_url is not used these configuration options make no changes.

@nywilken The properties option should set the options on the resulting image and not on the temporary image, so that it can be used even when not using external_source_image_url.

[Lirt]

Hi, I also have interest in this feature.

If I understand correctly what needs to be done is:

1. Create new configuration option such as uploaded_image_properties which is a map[string]string.
2. Pass properties to 2 upload actions - one for servers API and 1 for volumes API call in this block of code.
   1. Based on comment // set ImageMetadata before uploading to glance so the new image captured the desired values and the code it looks like when image is created using cinder it will already have properties set. I can't confirm this by experiment as openstack in our company uses glance to store images.
   2. *I assume Metadata struct is same as what Properties are called in the CLI.

References:

• Openstack API for ImageCreate
• CreateImage call that is used in the code