C#: Introduce IFileProvider interface.

Author: michaelnebel

csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/DependencyManager.cs

@@ -30,7 +30,7 @@ public sealed partial class DependencyManager : IDisposable, ICompilationInfoCon
         private readonly DependabotProxy? dependabotProxy;
         private readonly IDotNet dotnet;
         private readonly FileContent fileContent;
-        private readonly FileProvider fileProvider;
+        private readonly IFileProvider fileProvider;
 
         // Only used as a set, but ConcurrentDictionary is the only concurrent set in .NET.
         private readonly IDictionary<string, bool> usedReferences = new ConcurrentDictionary<string, bool>();

csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/FeedManager.cs

@@ -21,7 +21,7 @@ internal sealed partial class FeedManager : IDisposable
 
         private readonly ILogger logger;
         private readonly IDotNet dotnet;
-        private readonly FileProvider fileProvider;
+        private readonly IFileProvider fileProvider;
         private readonly DependabotProxy? dependabotProxy;
         private readonly DependencyDirectory emptyPackageDirectory;
         private readonly ImmutableHashSet<string> privateRegistryFeeds;
@@ -79,7 +79,7 @@ internal sealed partial class FeedManager : IDisposable
         /// </summary>
         public ImmutableHashSet<string> ReachableFallbackFeeds => lazyReachableFallbackFeeds.Value;
 
-        public FeedManager(ILogger logger, IDotNet dotnet, DependabotProxy? dependabotProxy, FileProvider fileProvider)
+        public FeedManager(ILogger logger, IDotNet dotnet, DependabotProxy? dependabotProxy, IFileProvider fileProvider)
         {
             this.logger = logger;
             this.dotnet = dotnet;

csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/FileProvider.cs

@@ -2,12 +2,11 @@
 using System.Collections.Generic;
 using System.IO;
 using System.Linq;
-using System.Security.Policy;
 using Semmle.Util.Logging;
 
 namespace Semmle.Extraction.CSharp.DependencyFetching
 {
-    public class FileProvider
+    internal class FileProvider : IFileProvider
     {
         private static readonly HashSet<string> binaryFileExtensions = [".dll", ".exe"]; // TODO: add more binary file extensions.
 

csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/IFileProvider.cs

@@ -0,0 +1,22 @@
+using System.Collections.Generic;
+using System.IO;
+
+namespace Semmle.Extraction.CSharp.DependencyFetching
+{
+    public interface IFileProvider
+    {
+        DirectoryInfo SourceDir { get; }
+        IEnumerable<string> SmallNonBinary { get; }
+        IEnumerable<string> Sources { get; }
+        ICollection<string> Projects { get; }
+        ICollection<string> Solutions { get; }
+        IEnumerable<string> Dlls { get; }
+        ICollection<string> NugetConfigs { get; }
+        ICollection<string> NugetExes { get; }
+        string? RootNugetConfig { get; }
+        IEnumerable<string> GlobalJsons { get; }
+        ICollection<string> PackagesConfigs { get; }
+        ICollection<string> RazorViews { get; }
+        ICollection<string> Resources { get; }
+    }
+}

csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/NugetPackageRestorer.cs

@@ -15,7 +15,7 @@ namespace Semmle.Extraction.CSharp.DependencyFetching
 {
     internal sealed partial class NugetPackageRestorer : IDisposable
     {
-        private readonly FileProvider fileProvider;
+        private readonly IFileProvider fileProvider;
         private readonly FileContent fileContent;
         private readonly IDotNet dotnet;
         private readonly IDiagnosticsWriter diagnosticsWriter;
@@ -29,7 +29,7 @@ internal sealed partial class NugetPackageRestorer : IDisposable
 
 
         public NugetPackageRestorer(
-            FileProvider fileProvider,
+            IFileProvider fileProvider,
             FileContent fileContent,
             IDotNet dotnet,
             DependabotProxy? dependabotProxy,

csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/PackagesConfigRestorer.cs

@@ -34,7 +34,7 @@ internal interface IPackagesConfigRestore
     /// </summary>
     internal class PackagesConfigRestoreFactory
     {
-        public static IPackagesConfigRestore Create(FileProvider fileProvider, DependencyDirectory packageDirectory, Semmle.Util.Logging.ILogger logger, FeedManager feedManager)
+        public static IPackagesConfigRestore Create(IFileProvider fileProvider, DependencyDirectory packageDirectory, Semmle.Util.Logging.ILogger logger, FeedManager feedManager)
         {
             if (SystemBuildActions.Instance.IsWindows() || SystemBuildActions.Instance.IsMonoInstalled())
             {
@@ -56,7 +56,7 @@ private class NugetExeWrapper : IPackagesConfigRestore
 
             public int PackageCount => fileProvider.PackagesConfigs.Count;
 
-            private readonly FileProvider fileProvider;
+            private readonly IFileProvider fileProvider;
 
             /// <summary>
             /// The packages directory.
@@ -75,7 +75,7 @@ private class NugetExeWrapper : IPackagesConfigRestore
             /// <summary>
             /// Create the package manager for a specified source tree.
             /// </summary>
-            public NugetExeWrapper(FileProvider fileProvider, DependencyDirectory packageDirectory, Semmle.Util.Logging.ILogger logger, FeedManager feedManager)
+            public NugetExeWrapper(IFileProvider fileProvider, DependencyDirectory packageDirectory, Semmle.Util.Logging.ILogger logger, FeedManager feedManager)
             {
                 this.fileProvider = fileProvider;
                 this.packageDirectory = packageDirectory;

csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/SourceGenerators/DotnetSourceGeneratorBase.cs

@@ -9,14 +9,14 @@ namespace Semmle.Extraction.CSharp.DependencyFetching
 {
     internal abstract class DotnetSourceGeneratorBase<T> : SourceGeneratorBase where T : DotnetSourceGeneratorWrapper
     {
-        protected readonly FileProvider fileProvider;
+        protected readonly IFileProvider fileProvider;
         protected readonly FileContent fileContent;
         protected readonly IDotNet dotnet;
         protected readonly ICompilationInfoContainer compilationInfoContainer;
         protected readonly IEnumerable<string> references;
 
         public DotnetSourceGeneratorBase(
-            FileProvider fileProvider,
+            IFileProvider fileProvider,
             FileContent fileContent,
             IDotNet dotnet,
             ICompilationInfoContainer compilationInfoContainer,

csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/SourceGenerators/RazorGenerator.cs

@@ -8,7 +8,7 @@ namespace Semmle.Extraction.CSharp.DependencyFetching
     internal class RazorGenerator : DotnetSourceGeneratorBase<Razor>
     {
         public RazorGenerator(
-            FileProvider fileProvider,
+            IFileProvider fileProvider,
             FileContent fileContent,
             IDotNet dotnet,
             ICompilationInfoContainer compilationInfoContainer,

csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/SourceGenerators/ResxGenerator.cs

@@ -10,7 +10,7 @@ internal class ResxGenerator : DotnetSourceGeneratorBase<Resx>
         private readonly string? sourceGeneratorFolder = null;
 
         public ResxGenerator(
-            FileProvider fileProvider,
+            IFileProvider fileProvider,
             FileContent fileContent,
             IDotNet dotnet,
             ICompilationInfoContainer compilationInfoContainer,