From 735e6e44237875639e3cca1817d9ce871df6f13f Mon Sep 17 00:00:00 2001
From: Cursor Agent <cursoragent@cursor.com>
Date: Mon, 31 Aug 2026 12:12:19 +0000
Subject: [PATCH] fix(version-check): log errors in maybePrefetchPatches catch
 blocks
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The two catch blocks in maybePrefetchPatches silently swallowed errors
from delta patch pre-fetching and patch cache cleanup. While these
operations are best-effort, the silent catches made it impossible to
diagnose failures even with --verbose. Added logger.debug() so errors
are visible in diagnostic output.

Co-authored-by: Miguel Betegón <miguelbetegongarcia@gmail.com>
---
 packages/cli/script/silent-catch-baseline.json | 2 +-
 packages/cli/src/lib/version-check.ts          | 9 +++++----
 2 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/packages/cli/script/silent-catch-baseline.json b/packages/cli/script/silent-catch-baseline.json
index 501d60e85..ef01b4c7d 100644
--- a/packages/cli/script/silent-catch-baseline.json
+++ b/packages/cli/script/silent-catch-baseline.json
@@ -80,7 +80,7 @@
   "src/lib/trace-target.ts": 1,
   "src/lib/upgrade.ts": 3,
   "src/lib/utils.ts": 1,
-  "src/lib/version-check.ts": 1,
+  "src/lib/version-check.ts": 0,
   "src/lib/which.ts": 1,
   "src/lib/wrangler.ts": 1
 }
diff --git a/packages/cli/src/lib/version-check.ts b/packages/cli/src/lib/version-check.ts
index 91ce947a9..c69ff0466 100644
--- a/packages/cli/src/lib/version-check.ts
+++ b/packages/cli/src/lib/version-check.ts
@@ -25,6 +25,7 @@ import { getEnv } from "./env.js";
 import { isUserError } from "./errors.js";
 import { cyan, muted } from "./formatters/colors.js";
 import { GLOBAL_FLAGS } from "./global-flags.js";
+import { logger } from "./logger.js";
 import { cleanupPatchCache } from "./patch-cache.js";
 import { fetchLatestFromGitHub, fetchLatestNightlyVersion } from "./upgrade.js";
 
@@ -237,15 +238,15 @@ async function maybePrefetchPatches(
     } else {
       await prefetchStablePatches(latestVersion, signal);
     }
-  } catch {
-    // Pre-fetch is best-effort — don't report errors
+  } catch (error) {
+    logger.debug("Delta patch pre-fetch failed (best-effort)", error);
   }
 
   // Opportunistic cleanup of stale cached patches
   try {
     await cleanupPatchCache();
-  } catch {
-    /* ignore */
+  } catch (error) {
+    logger.debug("Patch cache cleanup failed (best-effort)", error);
   }
 }