Skip to content

server: 'DictDescriptorStore' is missing 'commit()', causing 500 on registry writes #626

Description

@paul-gerber-svg

DictDescriptorStore (server/app/model/provider.py) has no commit() method, so it uses the SDK's default one, which just raises NotImplementedError(). The registry calls commit() on every add/update, so POST/PUT to /shell-descriptors returns 500 in the default config.

Proposed fix: add a no-op commit() to DictDescriptorStore, like the SDK's DictObjectStore already has.

Root cause is that the commit() method in the abstract base class AbstractObjectStore is not flagged as an abstract method.
We should consider adding the correct decorator.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions