Skip to content

Fix eslint errors #16

Description

@NicolasRitouet

When we introduced eslint to the deployd-cli codebase, a few eslint rules were throwing errors.
In order to move fast, I decided to change the rules and throw warning instead of errors for a few rules.

In order to have a clean codebase, we need to fix the code to allow eslint to throw normal errors for these rules.

ℹ️ This ticket has been labeled first-timers-only, it means that it's only available for people who never contributed to an open-source project. Feel free to ask questions and get help on gitter.

Todo

You can also send one PR per reactivated rules if you prefer.

rules to reactivate

  • prefer-const: 1, // 4 errors
  • no-unused-vars: 1, // 3 errors
  • no-use-before-define: 1, // 7 errors
  • one-var: 1, // 8 errors
  • consistent-return: 1, // 8 errors
  • no-param-reassign: 1, // 2 errors
  • global-require: 1, // 2 errors
  • import/no-dynamic-require: 1 // 1 error

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions