Skip to content

Some suggestions from a use case #7

Description

@acontreras89

You may have noticed I've been playing around with your wrapper :)

Here's a list of things I've found useful:

  • Pass the entire section id through context (rather than its numeric equivalent). This makes supporting custom section ids a no-brainer
  • Pass down rest props in Focusables. This will enable uses to disable them, for instance
  • Add config props to FocusableSections, just like the ones in SpatialNavigation
  • Let FocusableSections access the global config through context (maybe?)
  • Add support for all events
  • Rename onFocus (e.g. onFocused, making it consistent with js-spatial-navigation,) to not lose the ability to handle native focus events (after rest props are being passed down)
  • ...

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions