Skip to content
This repository was archived by the owner on Sep 7, 2022. It is now read-only.
This repository was archived by the owner on Sep 7, 2022. It is now read-only.

conflict of name 'name' #91

Description

@sjpt

dat.guiVR uses a function name() to set the label.
This conflicts with the pre-existing 'name' field in THREE objects.

This causes some issues, including breaking threejs inspector when inspecting dat.guiVR objects.

I suggest it be replaced by a get/set property 'label'; or (smaller change) renamed to 'label' or 'setName'.
I can't see an easy way to do this without breaking upward compatibility.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions