From 4022c6be8bdcae29725cd178e8b963a5eea41111 Mon Sep 17 00:00:00 2001 From: Paul Traylor Date: Tue, 1 Sep 2026 17:58:03 +0900 Subject: [PATCH] Show module path when logging In addition to logging the ID, the module_path can also be useful while debugging to know what is being run at a glance. --- threadmill/executor.py | 24 ++++++++++++++++++++---- 1 file changed, 20 insertions(+), 4 deletions(-) diff --git a/threadmill/executor.py b/threadmill/executor.py index f9490b3..b384d14 100644 --- a/threadmill/executor.py +++ b/threadmill/executor.py @@ -229,11 +229,19 @@ def retry_delay(task_result: TaskResult) -> datetime.timedelta | None: try: return task_result.task.retry(TaskContext(task_result=task_result)) except Exception: - logger.exception("Retry callback failed for task %r", task_result.id) + logger.exception( + "Retry callback failed for task '%s@%s'", + task_result.id, + task_result.task.module_path, + ) def execute_task_result(self, task_result: TaskResult) -> TaskResult: """Execute task from task result and update result lifecycle state.""" - logger.info("Executing task %r", task_result.id) + logger.info( + "Executing task '%s@%s'", + task_result.id, + task_result.task.module_path, + ) started_at = timezone.now() task_result = dataclasses.replace( task_result, @@ -252,7 +260,11 @@ def execute_task_result(self, task_result: TaskResult) -> TaskResult: errors=[*task_result.errors, WorkerThread.create_task_error(exception)], finished_at=timezone.now(), ) - logger.exception("Task failed %r", task_result.id) + logger.exception( + "Task '%s@%s' failed", + task_result.id, + task_result.task.module_path, + ) else: task_result = dataclasses.replace( task_result, @@ -262,7 +274,11 @@ def execute_task_result(self, task_result: TaskResult) -> TaskResult: object.__setattr__( task_result, "_return_value", normalize_json(return_value) ) - logger.info("Task successful %r", task_result.id) + logger.info( + "Task '%s@%s' succeeded", + task_result.id, + task_result.task.module_path, + ) finally: task_finished.send(TaskExecutor, task_result=task_result)