From b7086cbb2b0d59fb4e715646048f973b611ac16a Mon Sep 17 00:00:00 2001 From: Clement DAVID Date: Thu, 6 Aug 2026 15:04:49 +0200 Subject: [PATCH] KeyboardHandler#onPreKeyEvent() was never called On the JNI KeyboardHandler::OnPreKeyEvent() is checking a jnull value value on the Java allocated ref. However for ScopedJNIBoolRef an implicit conversion to bool happened, leading to a false value and early return. --- native/keyboard_handler.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/native/keyboard_handler.cpp b/native/keyboard_handler.cpp index 88bb6408..831c9bb7 100644 --- a/native/keyboard_handler.cpp +++ b/native/keyboard_handler.cpp @@ -51,7 +51,7 @@ bool KeyboardHandler::OnPreKeyEvent(CefRefPtr browser, return false; ScopedJNIBoolRef jboolRef(env, *is_keyboard_shortcut); - if (!jboolRef) + if (!jboolRef->get()) return false; jboolean jresult = JNI_FALSE;