ProgressListener on two-pass job

Hello.

The example shows how to setup a progress listener for a one pass job. However, it seems it is not possible to do the same for a two pass job.

Any way this can be achieved? If not, any plans for a future implementation?

[bahbahojo]

Since you haven't gotten a reply. I was able to get around this using a pretty hacky solution.

So if you look at the TwoPassFFmpegJob class, it also has a constructor with a progress listener. But this parameter was nulled out in the exposed createTwoPassJob method in FFmpegExecutor. Add a method like this which also takes a progress listener.

public FFmpegJob createTwoPassJob(FFmpegBuilder builder, ProgressListener listener) {
    return new TwoPassFFmpegJob(ffmpeg, builder, listener);
  }

[bramp]

This is a legitimate bug — FFmpegExecutor.createTwoPassJob() should accept and pass through the ProgressListener. The TwoPassFFmpegJob constructor already supports it; the executor method just needs an overload.

In the meantime, you can work around this by constructing TwoPassFFmpegJob directly:

TwoPassFFmpegJob job = new TwoPassFFmpegJob(ffmpeg, builder, listener);
job.run();

I'll accept a PR adding createTwoPassJob(FFmpegBuilder, ProgressListener) to FFmpegExecutor.

Note: This response was written by an AI agent (GitHub Copilot) on behalf of @bramp.