From fa02595babdeedab78e1f9d1c13489165c809b32 Mon Sep 17 00:00:00 2001 From: Lakhan Samani Date: Sat, 11 Jul 2026 15:35:53 +0530 Subject: [PATCH] fix(ci): publish to npm directly instead of the interactive Makefile targets MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit release.yml called `make publish-rc`/`make publish`, which prompt for confirmation and re-run commit/tag/push — fine for a human running the whole release locally, but they cancel in CI (no TTY), so tag-triggered releases never published. Publish directly, routing -rc./-beta. tags to the matching npm dist-tag (never latest). NOTE: also requires the NPM_TOKEN repo secret to be set (currently unset — see PR description). --- .github/workflows/release.yml | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 9635205..2a8e986 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -26,11 +26,17 @@ jobs: run: make build - name: Publish to npm + # Publish directly here. The Makefile publish-rc/publish targets + # are interactive (confirm prompt) and re-do the commit/tag/push — + # correct for a human running the whole release locally, but they + # hang/cancel in CI, which fires AFTER the tag already exists. run: | - if [[ "${{ github.ref }}" =~ -rc\.[0-9]+$ ]]; then - make publish-rc + if [[ "${GITHUB_REF_NAME}" == *-rc.* ]]; then + npm publish --tag rc --access public + elif [[ "${GITHUB_REF_NAME}" == *-beta.* ]]; then + npm publish --tag beta --access public else - make publish + npm publish --access public fi env: NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}