From 93dee4af77b505a0acfe7b3da38b34d86de27b28 Mon Sep 17 00:00:00 2001 From: avillarreal Date: Tue, 8 Sep 2026 12:02:57 -0500 Subject: [PATCH 1/5] Moving common compaction logs into TabletLogger --- .../org/apache/accumulo/core/logging/TabletLogger.java | 10 ++++++++++ .../compaction/coordinator/CompactionCoordinator.java | 2 +- .../accumulo/manager/tableOps/compact/CleanUp.java | 3 ++- .../manager/tableOps/compact/CompactionDriver.java | 4 ++-- .../org/apache/accumulo/tserver/tablet/Tablet.java | 2 +- 5 files changed, 16 insertions(+), 5 deletions(-) diff --git a/core/src/main/java/org/apache/accumulo/core/logging/TabletLogger.java b/core/src/main/java/org/apache/accumulo/core/logging/TabletLogger.java index 980b7863033..752f0c4d8b8 100644 --- a/core/src/main/java/org/apache/accumulo/core/logging/TabletLogger.java +++ b/core/src/main/java/org/apache/accumulo/core/logging/TabletLogger.java @@ -35,12 +35,14 @@ import org.apache.accumulo.core.metadata.StoredTabletFile; import org.apache.accumulo.core.metadata.TServerInstance; import org.apache.accumulo.core.metadata.TabletFile; +import org.apache.accumulo.core.metadata.schema.Ample; import org.apache.accumulo.core.metadata.schema.ExternalCompactionId; import org.apache.accumulo.core.spi.compaction.CompactionJob; import org.apache.accumulo.core.spi.compaction.CompactionKind; import org.apache.accumulo.core.tabletserver.log.LogEntry; import org.apache.accumulo.core.util.time.SteadyTime; import org.apache.commons.io.FileUtils; +import org.apache.hadoop.fs.Path; import org.apache.hadoop.io.Text; import org.slf4j.Logger; import org.slf4j.LoggerFactory; @@ -131,6 +133,10 @@ public static void fileReadFailed(String path, KeyExtent tablet, Exception e) { fileLog.error("For tablet {} failed to read {} ", tablet, path, e); } + public static void tabletNoDir(KeyExtent extent, Path path) { + fileLog.debug("Tablet {} had no dir, creating {}", extent, path); + } + /** * Lazily converts TableFile to file names. The lazy part is really important because when it is * not called with log.isDebugEnabled(). @@ -210,4 +216,8 @@ public static void walRefsChanged(KeyExtent extent, Collection refsSuppl walsLog.trace("{} has unflushed data in wals: {} ", extent, refsSupplier); } + public static void updateRejected(FateId fateId, Ample.ConditionalResult result) { + fileLog.debug("{} update for {} was rejected ", fateId, result.getExtent()); + } + } diff --git a/server/manager/src/main/java/org/apache/accumulo/manager/compaction/coordinator/CompactionCoordinator.java b/server/manager/src/main/java/org/apache/accumulo/manager/compaction/coordinator/CompactionCoordinator.java index 9aa3c643839..572f6d63137 100644 --- a/server/manager/src/main/java/org/apache/accumulo/manager/compaction/coordinator/CompactionCoordinator.java +++ b/server/manager/src/main/java/org/apache/accumulo/manager/compaction/coordinator/CompactionCoordinator.java @@ -411,7 +411,7 @@ private void checkTabletDir(KeyExtent extent, Path path) { } if (files == null) { - LOG.debug("Tablet {} had no dir, creating {}", extent, path); + TabletLogger.tabletNoDir(extent, path); ctx.getVolumeManager().mkdirs(path); } diff --git a/server/manager/src/main/java/org/apache/accumulo/manager/tableOps/compact/CleanUp.java b/server/manager/src/main/java/org/apache/accumulo/manager/tableOps/compact/CleanUp.java index 7b9a2fe9a5e..f7776de3e60 100644 --- a/server/manager/src/main/java/org/apache/accumulo/manager/tableOps/compact/CleanUp.java +++ b/server/manager/src/main/java/org/apache/accumulo/manager/tableOps/compact/CleanUp.java @@ -32,6 +32,7 @@ import org.apache.accumulo.core.fate.FateId; import org.apache.accumulo.core.fate.Repo; import org.apache.accumulo.core.fate.zookeeper.LockRange; +import org.apache.accumulo.core.logging.TabletLogger; import org.apache.accumulo.core.metadata.schema.Ample; import org.apache.accumulo.core.metadata.schema.Ample.ConditionalResult.Status; import org.apache.accumulo.core.metadata.schema.TabletMetadata; @@ -72,7 +73,7 @@ public long isReady(FateId fateId, FateEnv env) throws Exception { AtomicLong rejectedCount = new AtomicLong(0); Consumer resultConsumer = result -> { if (result.getStatus() == Status.REJECTED) { - log.debug("{} update for {} was rejected ", fateId, result.getExtent()); + TabletLogger.updateRejected(fateId, result); rejectedCount.incrementAndGet(); } }; diff --git a/server/manager/src/main/java/org/apache/accumulo/manager/tableOps/compact/CompactionDriver.java b/server/manager/src/main/java/org/apache/accumulo/manager/tableOps/compact/CompactionDriver.java index 9b5b484b4a8..85cdc9a8714 100644 --- a/server/manager/src/main/java/org/apache/accumulo/manager/tableOps/compact/CompactionDriver.java +++ b/server/manager/src/main/java/org/apache/accumulo/manager/tableOps/compact/CompactionDriver.java @@ -159,7 +159,7 @@ public int updateAndCheckTablets(FateEnv env, FateId fateId) Consumer resultConsumer = result -> { if (result.getStatus() == Status.REJECTED) { - log.debug("{} update for {} was rejected ", fateId, result.getExtent()); + TabletLogger.updateRejected(fateId, result); } // always remove extents from the map even if not successful in order to avoid placing too @@ -378,7 +378,7 @@ private void cleanupTabletMetadata(FateId fateId, ServerContext ctx) throws Exce AtomicLong rejectedCount = new AtomicLong(0); Consumer resultConsumer = result -> { if (result.getStatus() == Status.REJECTED) { - log.debug("{} update for {} was rejected ", fateId, result.getExtent()); + TabletLogger.updateRejected(fateId, result); rejectedCount.incrementAndGet(); } }; diff --git a/server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java b/server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java index 0e0f8d1d088..098ec90bccd 100644 --- a/server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java +++ b/server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java @@ -239,7 +239,7 @@ private void checkTabletDir(Path path) { } if (files == null) { - log.debug("Tablet {} had no dir, creating {}", extent, path); + TabletLogger.tabletNoDir(extent, path); getTabletServer().getVolumeManager().mkdirs(path); } checkedTabletDirs.add(path); From 7347079d4590d922a7f30b998cb3f2d9a7d2e78f Mon Sep 17 00:00:00 2001 From: avillarreal Date: Thu, 10 Sep 2026 15:05:11 -0500 Subject: [PATCH 2/5] Adding system properties to server documentation --- .../accumulo/core/conf/ConfigurationDocGen.java | 13 +++++++++++++ .../org/apache/accumulo/core/conf/Property.java | 11 +++++++++++ 2 files changed, 24 insertions(+) diff --git a/core/src/main/java/org/apache/accumulo/core/conf/ConfigurationDocGen.java b/core/src/main/java/org/apache/accumulo/core/conf/ConfigurationDocGen.java index 4595123deb7..f84d976e66f 100644 --- a/core/src/main/java/org/apache/accumulo/core/conf/ConfigurationDocGen.java +++ b/core/src/main/java/org/apache/accumulo/core/conf/ConfigurationDocGen.java @@ -22,6 +22,7 @@ import java.io.IOException; import java.io.PrintStream; +import java.util.List; import java.util.TreeMap; /** @@ -48,6 +49,10 @@ void generate() { beginTable("Type"); propertyTypeDescriptions(); + beginSection("Java System Properties"); + beginTable("Property"); + systemPropertyDescriptions(); + doc.close(); } @@ -144,6 +149,14 @@ void propertyTypeDescriptions() { } } + void systemPropertyDescriptions() { + doc.println("Below are properties used to modify the behavior of runtime."); + List systemProps = Property.getSystemProperties(); + for (String prop : systemProps) { + doc.println("| " + sanitize(prop) + " | " + "Description per prop" + " |"); + } + } + String sanitize(String str) { return str.replace("\n", "
"); } diff --git a/core/src/main/java/org/apache/accumulo/core/conf/Property.java b/core/src/main/java/org/apache/accumulo/core/conf/Property.java index ad738587091..317d778f515 100644 --- a/core/src/main/java/org/apache/accumulo/core/conf/Property.java +++ b/core/src/main/java/org/apache/accumulo/core/conf/Property.java @@ -21,11 +21,13 @@ import static org.apache.accumulo.core.Constants.DEFAULT_COMPACTION_SERVICE_NAME; import java.lang.annotation.Annotation; +import java.util.ArrayList; import java.util.Arrays; import java.util.Collections; import java.util.EnumSet; import java.util.HashMap; import java.util.HashSet; +import java.util.List; import java.util.Objects; import java.util.Set; import java.util.function.Predicate; @@ -38,6 +40,7 @@ import org.apache.accumulo.core.iterators.IteratorUtil.IteratorScope; import org.apache.accumulo.core.iteratorsImpl.system.DeletingIterator; import org.apache.accumulo.core.metadata.SystemTables; +import org.apache.accumulo.core.rpc.clients.TServerClient; import org.apache.accumulo.core.spi.compaction.RatioBasedCompactionPlanner; import org.apache.accumulo.core.spi.compaction.SimpleCompactionDispatcher; import org.apache.accumulo.core.spi.fs.RandomVolumeChooser; @@ -1861,6 +1864,14 @@ public static T createInstanceFromPropertyName(AccumuloConfiguration conf, P return ConfigurationTypeHelper.getClassInstance(null, clazzName, base, defaultInstance); } + public static List getSystemProperties() { + List systemProps = new ArrayList<>(); + systemProps.add(TServerClient.DEBUG_HOST); + systemProps.add(SiteConfiguration.ACCUMULO_PROPERTIES_PROPERTY); + + return systemProps; + } + static { // Precomputing information here avoids : // * Computing it each time a method is called From 2891e35a7b23c596309d7460aa3876bddc20f8e5 Mon Sep 17 00:00:00 2001 From: avillarreal Date: Fri, 11 Sep 2026 13:13:06 -0500 Subject: [PATCH 3/5] Create constants for codec properties, add to configuration doc --- .../core/conf/ConfigurationDocGen.java | 11 ++++---- .../apache/accumulo/core/conf/Property.java | 27 ++++++++++++++----- .../spi/file/rfile/compression/Bzip2.java | 4 ++- .../core/spi/file/rfile/compression/Lz4.java | 4 ++- .../core/spi/file/rfile/compression/Lzo.java | 4 ++- .../spi/file/rfile/compression/Snappy.java | 3 ++- .../spi/file/rfile/compression/ZStandard.java | 4 ++- 7 files changed, 40 insertions(+), 17 deletions(-) diff --git a/core/src/main/java/org/apache/accumulo/core/conf/ConfigurationDocGen.java b/core/src/main/java/org/apache/accumulo/core/conf/ConfigurationDocGen.java index f84d976e66f..9807b958917 100644 --- a/core/src/main/java/org/apache/accumulo/core/conf/ConfigurationDocGen.java +++ b/core/src/main/java/org/apache/accumulo/core/conf/ConfigurationDocGen.java @@ -22,7 +22,7 @@ import java.io.IOException; import java.io.PrintStream; -import java.util.List; +import java.util.Map; import java.util.TreeMap; /** @@ -50,6 +50,7 @@ void generate() { propertyTypeDescriptions(); beginSection("Java System Properties"); + doc.println("Below are properties used to modify the behavior of runtime.\n"); beginTable("Property"); systemPropertyDescriptions(); @@ -150,11 +151,9 @@ void propertyTypeDescriptions() { } void systemPropertyDescriptions() { - doc.println("Below are properties used to modify the behavior of runtime."); - List systemProps = Property.getSystemProperties(); - for (String prop : systemProps) { - doc.println("| " + sanitize(prop) + " | " + "Description per prop" + " |"); - } + Map systemProps = Property.getSystemProperties(); + systemProps.forEach( + (key, value) -> doc.println("| " + sanitize(key) + " | " + sanitize(value) + " |")); } String sanitize(String str) { diff --git a/core/src/main/java/org/apache/accumulo/core/conf/Property.java b/core/src/main/java/org/apache/accumulo/core/conf/Property.java index 317d778f515..47309e16394 100644 --- a/core/src/main/java/org/apache/accumulo/core/conf/Property.java +++ b/core/src/main/java/org/apache/accumulo/core/conf/Property.java @@ -21,13 +21,12 @@ import static org.apache.accumulo.core.Constants.DEFAULT_COMPACTION_SERVICE_NAME; import java.lang.annotation.Annotation; -import java.util.ArrayList; import java.util.Arrays; import java.util.Collections; import java.util.EnumSet; import java.util.HashMap; import java.util.HashSet; -import java.util.List; +import java.util.Map; import java.util.Objects; import java.util.Set; import java.util.function.Predicate; @@ -43,6 +42,11 @@ import org.apache.accumulo.core.rpc.clients.TServerClient; import org.apache.accumulo.core.spi.compaction.RatioBasedCompactionPlanner; import org.apache.accumulo.core.spi.compaction.SimpleCompactionDispatcher; +import org.apache.accumulo.core.spi.file.rfile.compression.Bzip2; +import org.apache.accumulo.core.spi.file.rfile.compression.Lz4; +import org.apache.accumulo.core.spi.file.rfile.compression.Lzo; +import org.apache.accumulo.core.spi.file.rfile.compression.Snappy; +import org.apache.accumulo.core.spi.file.rfile.compression.ZStandard; import org.apache.accumulo.core.spi.fs.RandomVolumeChooser; import org.apache.accumulo.core.spi.scan.ScanDispatcher; import org.apache.accumulo.core.spi.scan.ScanPrioritizer; @@ -1864,10 +1868,21 @@ public static T createInstanceFromPropertyName(AccumuloConfiguration conf, P return ConfigurationTypeHelper.getClassInstance(null, clazzName, base, defaultInstance); } - public static List getSystemProperties() { - List systemProps = new ArrayList<>(); - systemProps.add(TServerClient.DEBUG_HOST); - systemProps.add(SiteConfiguration.ACCUMULO_PROPERTIES_PROPERTY); + /** + * A set Map of identified System Properties to be used in ConfigurationDocGen.java + * + * @return A Map of each property's value and description as Strings + */ + public static Map getSystemProperties() { + Map systemProps = new HashMap<>(Map.of()); + systemProps.put(TServerClient.DEBUG_HOST, "Debug host description"); + systemProps.put(SiteConfiguration.ACCUMULO_PROPERTIES_PROPERTY, + "accumulo properties description"); + systemProps.put(Bzip2.CODEC_BZIP2, "Codec BZip2 Compression Algorithm"); + systemProps.put(Lz4.CODEC_LZ4, "Codec LZ4 Compression Algorithm"); + systemProps.put(Lzo.CODEC_LZO, "Codec LZO Compression Algorithm"); + systemProps.put(Snappy.CODEC_SNAPPY, "Codec Snappy Compression Algorithm"); + systemProps.put(ZStandard.CODEC_ZSTANDARD, "Codec ZStandard Compression Algorithm"); return systemProps; } diff --git a/core/src/main/java/org/apache/accumulo/core/spi/file/rfile/compression/Bzip2.java b/core/src/main/java/org/apache/accumulo/core/spi/file/rfile/compression/Bzip2.java index 4f813da5eb3..6548bd2c1e3 100644 --- a/core/src/main/java/org/apache/accumulo/core/spi/file/rfile/compression/Bzip2.java +++ b/core/src/main/java/org/apache/accumulo/core/spi/file/rfile/compression/Bzip2.java @@ -20,6 +20,8 @@ public class Bzip2 implements CompressionAlgorithmConfiguration { + public static final String CODEC_BZIP2 = "io.compression.codec.bzip2.class"; + @Override public String getName() { return "bzip2"; @@ -32,7 +34,7 @@ public String getCodecClassName() { @Override public String getCodecClassNameProperty() { - return "io.compression.codec.bzip2.class"; + return CODEC_BZIP2; } @Override diff --git a/core/src/main/java/org/apache/accumulo/core/spi/file/rfile/compression/Lz4.java b/core/src/main/java/org/apache/accumulo/core/spi/file/rfile/compression/Lz4.java index 274e3f3f4ac..4ac2790f416 100644 --- a/core/src/main/java/org/apache/accumulo/core/spi/file/rfile/compression/Lz4.java +++ b/core/src/main/java/org/apache/accumulo/core/spi/file/rfile/compression/Lz4.java @@ -20,6 +20,8 @@ public class Lz4 implements CompressionAlgorithmConfiguration { + public static final String CODEC_LZ4 = "io.compression.codec.lz4.class"; + @Override public String getName() { return "lz4"; @@ -32,7 +34,7 @@ public String getCodecClassName() { @Override public String getCodecClassNameProperty() { - return "io.compression.codec.lz4.class"; + return CODEC_LZ4; } @Override diff --git a/core/src/main/java/org/apache/accumulo/core/spi/file/rfile/compression/Lzo.java b/core/src/main/java/org/apache/accumulo/core/spi/file/rfile/compression/Lzo.java index 0c20138f02b..0af52d9e601 100644 --- a/core/src/main/java/org/apache/accumulo/core/spi/file/rfile/compression/Lzo.java +++ b/core/src/main/java/org/apache/accumulo/core/spi/file/rfile/compression/Lzo.java @@ -20,6 +20,8 @@ public class Lzo implements CompressionAlgorithmConfiguration { + public static final String CODEC_LZO = "io.compression.codec.lzo.class"; + @Override public String getName() { return "lzo"; @@ -32,7 +34,7 @@ public String getCodecClassName() { @Override public String getCodecClassNameProperty() { - return "io.compression.codec.lzo.class"; + return CODEC_LZO; } @Override diff --git a/core/src/main/java/org/apache/accumulo/core/spi/file/rfile/compression/Snappy.java b/core/src/main/java/org/apache/accumulo/core/spi/file/rfile/compression/Snappy.java index 173afa48c9e..5636ae55f1b 100644 --- a/core/src/main/java/org/apache/accumulo/core/spi/file/rfile/compression/Snappy.java +++ b/core/src/main/java/org/apache/accumulo/core/spi/file/rfile/compression/Snappy.java @@ -19,6 +19,7 @@ package org.apache.accumulo.core.spi.file.rfile.compression; public class Snappy implements CompressionAlgorithmConfiguration { + public static final String CODEC_SNAPPY = "io.compression.codec.snappy.class"; @Override public String getName() { @@ -32,7 +33,7 @@ public String getCodecClassName() { @Override public String getCodecClassNameProperty() { - return "io.compression.codec.snappy.class"; + return CODEC_SNAPPY; } @Override diff --git a/core/src/main/java/org/apache/accumulo/core/spi/file/rfile/compression/ZStandard.java b/core/src/main/java/org/apache/accumulo/core/spi/file/rfile/compression/ZStandard.java index 1b21845e171..74daac6adad 100644 --- a/core/src/main/java/org/apache/accumulo/core/spi/file/rfile/compression/ZStandard.java +++ b/core/src/main/java/org/apache/accumulo/core/spi/file/rfile/compression/ZStandard.java @@ -20,6 +20,8 @@ public class ZStandard implements CompressionAlgorithmConfiguration { + public static final String CODEC_ZSTANDARD = "io.compression.codec.zstd.class"; + @Override public String getName() { return "zstd"; @@ -32,7 +34,7 @@ public String getCodecClassName() { @Override public String getCodecClassNameProperty() { - return "io.compression.codec.zstd.class"; + return CODEC_ZSTANDARD; } @Override From 30138624c6f21870415e12d0a0197a541c38066b Mon Sep 17 00:00:00 2001 From: avillarreal Date: Fri, 11 Sep 2026 13:27:40 -0500 Subject: [PATCH 4/5] Undo changes from accidental commit --- .../org/apache/accumulo/core/logging/TabletLogger.java | 10 ---------- .../compaction/coordinator/CompactionCoordinator.java | 2 +- .../accumulo/manager/tableOps/compact/CleanUp.java | 3 +-- .../manager/tableOps/compact/CompactionDriver.java | 4 ++-- .../org/apache/accumulo/tserver/tablet/Tablet.java | 2 +- 5 files changed, 5 insertions(+), 16 deletions(-) diff --git a/core/src/main/java/org/apache/accumulo/core/logging/TabletLogger.java b/core/src/main/java/org/apache/accumulo/core/logging/TabletLogger.java index 752f0c4d8b8..980b7863033 100644 --- a/core/src/main/java/org/apache/accumulo/core/logging/TabletLogger.java +++ b/core/src/main/java/org/apache/accumulo/core/logging/TabletLogger.java @@ -35,14 +35,12 @@ import org.apache.accumulo.core.metadata.StoredTabletFile; import org.apache.accumulo.core.metadata.TServerInstance; import org.apache.accumulo.core.metadata.TabletFile; -import org.apache.accumulo.core.metadata.schema.Ample; import org.apache.accumulo.core.metadata.schema.ExternalCompactionId; import org.apache.accumulo.core.spi.compaction.CompactionJob; import org.apache.accumulo.core.spi.compaction.CompactionKind; import org.apache.accumulo.core.tabletserver.log.LogEntry; import org.apache.accumulo.core.util.time.SteadyTime; import org.apache.commons.io.FileUtils; -import org.apache.hadoop.fs.Path; import org.apache.hadoop.io.Text; import org.slf4j.Logger; import org.slf4j.LoggerFactory; @@ -133,10 +131,6 @@ public static void fileReadFailed(String path, KeyExtent tablet, Exception e) { fileLog.error("For tablet {} failed to read {} ", tablet, path, e); } - public static void tabletNoDir(KeyExtent extent, Path path) { - fileLog.debug("Tablet {} had no dir, creating {}", extent, path); - } - /** * Lazily converts TableFile to file names. The lazy part is really important because when it is * not called with log.isDebugEnabled(). @@ -216,8 +210,4 @@ public static void walRefsChanged(KeyExtent extent, Collection refsSuppl walsLog.trace("{} has unflushed data in wals: {} ", extent, refsSupplier); } - public static void updateRejected(FateId fateId, Ample.ConditionalResult result) { - fileLog.debug("{} update for {} was rejected ", fateId, result.getExtent()); - } - } diff --git a/server/manager/src/main/java/org/apache/accumulo/manager/compaction/coordinator/CompactionCoordinator.java b/server/manager/src/main/java/org/apache/accumulo/manager/compaction/coordinator/CompactionCoordinator.java index 572f6d63137..9aa3c643839 100644 --- a/server/manager/src/main/java/org/apache/accumulo/manager/compaction/coordinator/CompactionCoordinator.java +++ b/server/manager/src/main/java/org/apache/accumulo/manager/compaction/coordinator/CompactionCoordinator.java @@ -411,7 +411,7 @@ private void checkTabletDir(KeyExtent extent, Path path) { } if (files == null) { - TabletLogger.tabletNoDir(extent, path); + LOG.debug("Tablet {} had no dir, creating {}", extent, path); ctx.getVolumeManager().mkdirs(path); } diff --git a/server/manager/src/main/java/org/apache/accumulo/manager/tableOps/compact/CleanUp.java b/server/manager/src/main/java/org/apache/accumulo/manager/tableOps/compact/CleanUp.java index f7776de3e60..7b9a2fe9a5e 100644 --- a/server/manager/src/main/java/org/apache/accumulo/manager/tableOps/compact/CleanUp.java +++ b/server/manager/src/main/java/org/apache/accumulo/manager/tableOps/compact/CleanUp.java @@ -32,7 +32,6 @@ import org.apache.accumulo.core.fate.FateId; import org.apache.accumulo.core.fate.Repo; import org.apache.accumulo.core.fate.zookeeper.LockRange; -import org.apache.accumulo.core.logging.TabletLogger; import org.apache.accumulo.core.metadata.schema.Ample; import org.apache.accumulo.core.metadata.schema.Ample.ConditionalResult.Status; import org.apache.accumulo.core.metadata.schema.TabletMetadata; @@ -73,7 +72,7 @@ public long isReady(FateId fateId, FateEnv env) throws Exception { AtomicLong rejectedCount = new AtomicLong(0); Consumer resultConsumer = result -> { if (result.getStatus() == Status.REJECTED) { - TabletLogger.updateRejected(fateId, result); + log.debug("{} update for {} was rejected ", fateId, result.getExtent()); rejectedCount.incrementAndGet(); } }; diff --git a/server/manager/src/main/java/org/apache/accumulo/manager/tableOps/compact/CompactionDriver.java b/server/manager/src/main/java/org/apache/accumulo/manager/tableOps/compact/CompactionDriver.java index 85cdc9a8714..9b5b484b4a8 100644 --- a/server/manager/src/main/java/org/apache/accumulo/manager/tableOps/compact/CompactionDriver.java +++ b/server/manager/src/main/java/org/apache/accumulo/manager/tableOps/compact/CompactionDriver.java @@ -159,7 +159,7 @@ public int updateAndCheckTablets(FateEnv env, FateId fateId) Consumer resultConsumer = result -> { if (result.getStatus() == Status.REJECTED) { - TabletLogger.updateRejected(fateId, result); + log.debug("{} update for {} was rejected ", fateId, result.getExtent()); } // always remove extents from the map even if not successful in order to avoid placing too @@ -378,7 +378,7 @@ private void cleanupTabletMetadata(FateId fateId, ServerContext ctx) throws Exce AtomicLong rejectedCount = new AtomicLong(0); Consumer resultConsumer = result -> { if (result.getStatus() == Status.REJECTED) { - TabletLogger.updateRejected(fateId, result); + log.debug("{} update for {} was rejected ", fateId, result.getExtent()); rejectedCount.incrementAndGet(); } }; diff --git a/server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java b/server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java index 098ec90bccd..0e0f8d1d088 100644 --- a/server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java +++ b/server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java @@ -239,7 +239,7 @@ private void checkTabletDir(Path path) { } if (files == null) { - TabletLogger.tabletNoDir(extent, path); + log.debug("Tablet {} had no dir, creating {}", extent, path); getTabletServer().getVolumeManager().mkdirs(path); } checkedTabletDirs.add(path); From 744225083585db43ae68cec685f5ca97cef0922c Mon Sep 17 00:00:00 2001 From: avillarreal Date: Fri, 11 Sep 2026 14:33:47 -0500 Subject: [PATCH 5/5] Code review updates, update text descriptions of system properties --- .../accumulo/core/conf/ConfigurationDocGen.java | 2 +- .../org/apache/accumulo/core/conf/Property.java | 15 ++++++++------- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/core/src/main/java/org/apache/accumulo/core/conf/ConfigurationDocGen.java b/core/src/main/java/org/apache/accumulo/core/conf/ConfigurationDocGen.java index 9807b958917..a216dfdd63b 100644 --- a/core/src/main/java/org/apache/accumulo/core/conf/ConfigurationDocGen.java +++ b/core/src/main/java/org/apache/accumulo/core/conf/ConfigurationDocGen.java @@ -50,7 +50,7 @@ void generate() { propertyTypeDescriptions(); beginSection("Java System Properties"); - doc.println("Below are properties used to modify the behavior of runtime.\n"); + doc.println("Below are properties used to modify the runtime behavior.\n"); beginTable("Property"); systemPropertyDescriptions(); diff --git a/core/src/main/java/org/apache/accumulo/core/conf/Property.java b/core/src/main/java/org/apache/accumulo/core/conf/Property.java index 47309e16394..6d9f2052c59 100644 --- a/core/src/main/java/org/apache/accumulo/core/conf/Property.java +++ b/core/src/main/java/org/apache/accumulo/core/conf/Property.java @@ -1875,14 +1875,15 @@ public static T createInstanceFromPropertyName(AccumuloConfiguration conf, P */ public static Map getSystemProperties() { Map systemProps = new HashMap<>(Map.of()); - systemProps.put(TServerClient.DEBUG_HOST, "Debug host description"); + systemProps.put(TServerClient.DEBUG_HOST, + "Set to host:port for the client to connect to a specific server."); systemProps.put(SiteConfiguration.ACCUMULO_PROPERTIES_PROPERTY, - "accumulo properties description"); - systemProps.put(Bzip2.CODEC_BZIP2, "Codec BZip2 Compression Algorithm"); - systemProps.put(Lz4.CODEC_LZ4, "Codec LZ4 Compression Algorithm"); - systemProps.put(Lzo.CODEC_LZO, "Codec LZO Compression Algorithm"); - systemProps.put(Snappy.CODEC_SNAPPY, "Codec Snappy Compression Algorithm"); - systemProps.put(ZStandard.CODEC_ZSTANDARD, "Codec ZStandard Compression Algorithm"); + "Path to accumulo.properties file."); + systemProps.put(Bzip2.CODEC_BZIP2, "BZip2 Codec Compression Algorithm."); + systemProps.put(Lz4.CODEC_LZ4, "LZ4 Codec Compression Algorithm."); + systemProps.put(Lzo.CODEC_LZO, "LZO Codec Compression Algorithm."); + systemProps.put(Snappy.CODEC_SNAPPY, "Snappy Codec Compression Algorithm."); + systemProps.put(ZStandard.CODEC_ZSTANDARD, "ZStandard Codec Compression Algorithm."); return systemProps; }