diff --git a/CHANGELOG.md b/CHANGELOG.md index 18747b5f3..853a7ca37 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - feat: update llama.cpp to ggml-org/llama.cpp@4df29be4f - fix(example): retain recurrent state for server MTP rollback - feat: update llama.cpp to ggml-org/llama.cpp@adb55e514 +- fix(server): show falsey defaults in CLI help by @cupkk in #2355 ## [0.3.34] diff --git a/llama_cpp/server/cli.py b/llama_cpp/server/cli.py index 171b8db30..3a5cde9cd 100644 --- a/llama_cpp/server/cli.py +++ b/llama_cpp/server/cli.py @@ -84,7 +84,7 @@ def add_args_from_model(parser: argparse.ArgumentParser, model: Type[BaseModel]) for name, field in model.model_fields.items(): description = field.description - if field.default and description and not field.is_required(): + if description and not field.is_required() and field.default is not None: description += f" (default: {field.default})" base_type = ( _get_base_type(field.annotation) if field.annotation is not None else str