fix: review feedback

Signed-off-by: romanetar <roman_ag@hotmail.com>

Author: romanetar

app/Http/Controllers/Apis/Protected/Summit/Factories/SummitSponsorshipAddOnTypeValidationRulesFactory.php

@@ -30,7 +30,7 @@ public static function buildForAdd(array $payload = []): array
     public static function buildForUpdate(array $payload = []): array
     {
         return [
-            'name' => 'sometimes|string|max:255',
+            'name' => 'sometimes|required|string|max:255',
         ];
     }
 }

app/ModelSerializers/Summit/SummitSponsorshipAddOnSerializer.php

@@ -23,8 +23,9 @@
 final class SummitSponsorshipAddOnSerializer extends SilverStripeSerializer
 {
     protected static $array_mappings = [
-        'Name'         => 'name:json_string',
-        'TypeId'       => 'type_id:json_int',
+        'Name'          => 'name:json_string',
+        'TypeId'        => 'type_id:json_int',
+        'TypeName'      => 'type_name:json_string',
         'SponsorshipId' => 'sponsorship_id:json_int',
     ];
 

app/Models/Foundation/Summit/SummitSponsorshipAddOn.php

@@ -72,6 +72,11 @@ public function getType(): ?SummitSponsorshipAddOnType
         return $this->type;
     }
 
+    public function getTypeName(): ?string
+    {
+        return $this->type?->getName();
+    }
+
     public function setType(SummitSponsorshipAddOnType $type): void
     {
         $this->type = $type;

app/Repositories/Summit/DoctrineSummitSponsorshipAddOnRepository.php

@@ -67,6 +67,7 @@ protected function getOrderMappings(): array
         return [
             'id'   => 'e.id',
             'name' => 'e.name',
+            'type' => 'at.name',
         ];
     }
 
@@ -98,4 +99,4 @@ public function countByAddOnType(int $type_id): int
             ->setParameter('type_id', $type_id)
             ->getSingleScalarResult();
     }
-}
+}

database/migrations/model/Version20260615000001.php

@@ -52,8 +52,9 @@ public function up(Schema $schema): void
         }
 
         // Seed the four types that correspond to the old string constants.
+        // INSERT IGNORE makes this safe to re-run (unique constraint on Name).
         $this->addSql(<<<SQL
-            INSERT INTO `SummitSponsorshipAddOnType` (`Created`, `LastEdited`, `Name`) VALUES
+            INSERT IGNORE INTO `SummitSponsorshipAddOnType` (`Created`, `LastEdited`, `Name`) VALUES
                 (NOW(), NOW(), 'Booth'),
                 (NOW(), NOW(), 'Meeting_Room'),
                 (NOW(), NOW(), 'Schedule_Spot'),

tests/oauth2/OAuth2SummitSponsorshipAddOnTypesApiControllerTest.php

@@ -227,6 +227,24 @@ public function testUpdate(): void
         $this->assertEquals($new_name, $type->name);
     }
 
+    public function testUpdateWithEmptyName(): void
+    {
+        $params = ['id' => self::$default_type->getId()];
+
+        $this->action(
+            "PUT",
+            "OAuth2SummitSponsorshipAddOnTypesApiController@update",
+            $params,
+            [],
+            [],
+            [],
+            $this->getAuthHeaders(),
+            json_encode(['name' => ''])
+        );
+
+        $this->assertResponseStatus(412);
+    }
+
     public function testUpdateNotFound(): void
     {
         $params = ['id' => PHP_INT_MAX];