Skip to content

[P3][Review] Delete tracked developer virtual-environment launchers #106

Description

@karlwaldman

Review-only / approval gate

No implementation, PR merge, package publication or production mutation until the owner approves the full sprint plan.

Evidence

Reviewed main 31b8d80686495c5d6dcac0846d6e5a2c8d4bce8b.

git ls-tree -r main build-env returns 49 tracked entries, including bin/pip, bin/pytest, activation scripts, pyvenv.cfg and lib64 symlink. These are machine-specific environment artifacts, not SDK source. The local 34 MB directory is NOT all tracked; only the 49 entries are in scope.

Preferred smallest change

Delete tracked build-env launchers/config/symlink after checking no CI/package script depends on them; retain pyproject dependency declarations and clean-wheel smoke. Ignore recreated developer environments. No history rewrite or deletion of a developer's actual environment.

Acceptance / negative-path tests

Fresh dependency install and existing tests/build work without tracked environment files; sdist/wheel inventories exclude virtualenv artifacts; repository reference search proves no required consumer.

Risk and PR gate

P2, isolated correction; preserve public API compatibility.
One focused issue PR; independent adversarial review must challenge deletion safety, public compatibility, failure recovery and whether a smaller deletion suffices. Include red/green test evidence and packed/installable artifact proof for any published SDK/MCP change. Merge only in the approved priority order after reviewer objections are resolved. Do not publish a breaking change as a patch. If already fixed at execution time, record evidence and skip without a cosmetic PR.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions