From d06005184a4902a2f0a34ce43a72c1819e36d0ef Mon Sep 17 00:00:00 2001 From: Robin Hermans Date: Fri, 28 Aug 2026 09:45:41 +0200 Subject: [PATCH] chore: address Copilot review on #26 - drop mavenLocal() from doclet, document JDK 25 The doclet resolved microdocs-core-java from mavenLocal() before Artifact Registry, so a stale ~/.m2 copy could mask what is actually published and make local builds disagree with publish.sh/CI. publish.sh publishes core to the registry before the doclet builds, so mavenLocal() is not needed here. README still claimed master is based on Java 21; it has been on JDK 25 since MXTS-77488. --- README.md | 5 +++-- microdocs-crawler-doclet/build.gradle | 1 - 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index ada0cf8..0965f44 100644 --- a/README.md +++ b/README.md @@ -8,6 +8,8 @@ Artifacts publish to Maxxton's internal Maven registry, not Maven Central - no G `microdocs-crawler-gradle` and `microdocs-core-java` use the `com.maxxton.convention` plugin, which configures the publication and registry automatically. `microdocs-crawler-doclet` never publishes its own artifact - only its fat jar is bundled into `microdocs-crawler-gradle`'s published jar. +Released versions are immutable in Artifact Registry: republishing a version that already exists fails with `400 Bad Request`. Bump the version rather than republishing. + To publish a new version: 1. Bump `version` in `gradle.properties` for whichever module(s) changed. 2. Run: @@ -16,5 +18,4 @@ $ ./publish.sh ``` ### Java 8 -Checkout the java8 branch for a Java 8 compatible version. The master branch is based on Java 21. - +Checkout the java8 branch for a Java 8 compatible version. The master branch is based on Java 25. diff --git a/microdocs-crawler-doclet/build.gradle b/microdocs-crawler-doclet/build.gradle index 6e70a11..80a4cb0 100644 --- a/microdocs-crawler-doclet/build.gradle +++ b/microdocs-crawler-doclet/build.gradle @@ -5,7 +5,6 @@ apply plugin: 'base' repositories { mavenCentral() - mavenLocal() maven { url "artifactregistry://europe-maven.pkg.dev/dynamic-concept-192711/maxxton-maven-virtual" }