Skip to content

EntryService.CreateAsync confusion #5

Description

@cocowalla

I'm a bit confused about how new entries are being created in EntryService.CreateAsync:

  1. _encrypter.GetSalt(randomSecureKey) is called to generate a salt - but the parameter randomSecureKey is never actually used by GetSalt
  2. var randomSecureKey = _encrypter.GetRandomSecureKey(); is called to generate a random encryption key, but this key is only used in the call to GetSalt mentioned in (1)

I guess this is just a hangover from some refactoring, but thought it worth mentioning.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions