Follow-up to #924.
certbot renew --once is the cron/one-shot entry point. #924 made it invoke the renewed_hook (correct — a one-shot renewal that skips the reload hook leaves the serving process on the old cert), but hook failures are only logged:
// dstack/certbot/src/bot.rs
match std::process::Command::new("/bin/sh").arg("-c").arg(hook).status() {
Ok(status) if status.success() => {}
Ok(status) => error!("renewed hook failed with status: {status}"),
Err(error) => error!("failed to run renewed hook: {error:?}"),
}
Ok(true)
So renew_and_run_hook returns Ok(true) regardless, and certbot renew --once exits 0 even when the hook never ran or exited non-zero. A cron job or systemd OneShot unit wrapping this sees success while the certificate on disk is new and the serving process is still holding the old one — exactly the failure that is supposed to be visible.
Swallowing the error is right for the daemon (the next interval retries), wrong for --once (there is no next interval).
Proposal
Split the two semantics. Options, roughly in order of preference:
- Have
renew_and_run_hook return the hook outcome (e.g. Result<Outcome> carrying hook_failed) and let the --once path in cli/src/main.rs turn a hook failure into a non-zero exit, while run() keeps logging and continuing.
- Add a
fail_on_hook_error: bool parameter, set from the once flag.
Either way the daemon loop must keep its current behaviour: a failing hook should not abort the loop.
Follow-up to #924.
certbot renew --onceis the cron/one-shot entry point. #924 made it invoke therenewed_hook(correct — a one-shot renewal that skips the reload hook leaves the serving process on the old cert), but hook failures are only logged:So
renew_and_run_hookreturnsOk(true)regardless, andcertbot renew --onceexits 0 even when the hook never ran or exited non-zero. A cron job or systemdOneShotunit wrapping this sees success while the certificate on disk is new and the serving process is still holding the old one — exactly the failure that is supposed to be visible.Swallowing the error is right for the daemon (the next interval retries), wrong for
--once(there is no next interval).Proposal
Split the two semantics. Options, roughly in order of preference:
renew_and_run_hookreturn the hook outcome (e.g.Result<Outcome>carryinghook_failed) and let the--oncepath incli/src/main.rsturn a hook failure into a non-zero exit, whilerun()keeps logging and continuing.fail_on_hook_error: boolparameter, set from theonceflag.Either way the daemon loop must keep its current behaviour: a failing hook should not abort the loop.