|
if attempts <= self._max_retry: |
This line uses self._max_retry to return the failed exception or RetriesExhaustedError while the loop in :908 uses the overriden local max_retry . I suppose this was a miss from commit 2b077fc that changed :908 but not this line.
We have an edge case, where the method is called with a different max_retry than the client default self._max_retry
- if
max_retry < self._max_retry this will be raising the inner (eg. ConnectionRefused) exception rather than RetriesExhaustedError . Different than anticipated.
- if
max_retry > self._max_retry and there is some 40x return while in the max_retry - self._max_retry -th attempt, instead of the 40x error we will see a [premature] RetriesExhaustedError.
python-redfish-library/src/redfish/rest/v1.py
Line 966 in f8d7a89
This line uses
self._max_retryto return the failed exception orRetriesExhaustedErrorwhile the loop in :908 uses the overriden localmax_retry. I suppose this was a miss from commit 2b077fc that changed :908 but not this line.We have an edge case, where the method is called with a different
max_retrythan the client defaultself._max_retrymax_retry<self._max_retrythis will be raising the inner (eg. ConnectionRefused) exception rather thanRetriesExhaustedError. Different than anticipated.max_retry>self._max_retryand there is some 40x return while in themax_retry - self._max_retry-th attempt, instead of the 40x error we will see a [premature] RetriesExhaustedError.